[glib/wip/pwithnall/2785-macos-fd-close-test-failure] gstdio: Temporarily disable g_close() warning on macOS




commit 5190354ad95c5a10fdde037de8177797ae4a7384
Author: Philip Withnall <pwithnall endlessos org>
Date:   Tue Oct 18 15:41:30 2022 +0100

    gstdio: Temporarily disable g_close() warning on macOS
    
    It causes the tests to fail, which suggests some latent FD handling bug
    on macOS (but not other platforms).
    
    Unfortunately I’m unable to debug that due to not having access to a
    macOS machine, and it’s blocking CI for the rest of the project.
    
    So disable it on macOS for now, until someone with access to a macOS
    machine can take a look.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #2785

 glib/gstdio.c | 6 ++++++
 1 file changed, 6 insertions(+)
---
diff --git a/glib/gstdio.c b/glib/gstdio.c
index ed46bdf2dd..22d1159ce5 100644
--- a/glib/gstdio.c
+++ b/glib/gstdio.c
@@ -1802,7 +1802,13 @@ g_close (gint       fd,
                * not necessarily in the caller of g_close(), but somebody else
                * might have wrongly closed fd. In any case, there is a serious bug
                * somewhere. */
+              /* FIXME: This causes a number of unit test failures on macOS.
+               * Disabling the message for now until someone with access to a
+               * macOS machine can investigate.
+               * See https://gitlab.gnome.org/GNOME/glib/-/issues/2785 */
+#ifndef HAVE_COCOA
               g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed 
up", fd);
+#endif
             }
           else
             {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]