[krb5-auth-dialog] prefs: Simplify browse_certs
- From: Guido Günther <guidog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [krb5-auth-dialog] prefs: Simplify browse_certs
- Date: Fri, 14 Oct 2022 19:53:23 +0000 (UTC)
commit cd795f74a423effc97cd9a34f4ae0803e880c1aa
Author: Guido Günther <agx sigxcpu org>
Date: Thu Oct 13 17:35:06 2022 +0200
prefs: Simplify browse_certs
This will help later on
src/ka-preferences.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/src/ka-preferences.c b/src/ka-preferences.c
index 35f591c..48d3095 100644
--- a/src/ka-preferences.c
+++ b/src/ka-preferences.c
@@ -361,8 +361,9 @@ static void
ka_preferences_browse_certs (KaPreferences *self, GtkEntry *entry)
{
GtkWidget *filechooser;
- GtkFileFilter *cert_filter, *all_filter;
- gchar *filename = NULL;
+ g_autoptr(GtkFileFilter) cert_filter = g_object_ref_sink (gtk_file_filter_new ());
+ g_autoptr(GtkFileFilter) all_filter = g_object_ref_sink (gtk_file_filter_new ());
+ g_autofree gchar *filename = NULL;
const gchar *current;
gint ret;
@@ -380,11 +381,10 @@ ka_preferences_browse_certs (KaPreferences *self, GtkEntry *entry)
(const gchar*)¤t[strlen(PKINIT_FILE)]);
}
- cert_filter = g_object_ref_sink (gtk_file_filter_new ());
gtk_file_filter_add_mime_type (cert_filter, "application/x-x509-ca-cert");
gtk_file_filter_set_name (cert_filter, _("X509 Certificates"));
gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (filechooser), cert_filter);
- all_filter = g_object_ref_sink (gtk_file_filter_new ());
+
gtk_file_filter_add_pattern (all_filter, "*");
gtk_file_filter_set_name (all_filter, _("all files"));
gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (filechooser), all_filter);
@@ -395,13 +395,9 @@ ka_preferences_browse_certs (KaPreferences *self, GtkEntry *entry)
gtk_widget_destroy (GTK_WIDGET(filechooser));
if (filename) {
- gchar *cert = g_strconcat (PKINIT_FILE, filename, NULL);
+ g_autofree gchar *cert = g_strconcat (PKINIT_FILE, filename, NULL);
gtk_entry_set_text (entry, cert);
- g_free (cert);
}
- g_object_unref (cert_filter);
- g_object_unref (all_filter);
- g_free (filename);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]