[gnome-builder/wip/chergert/lsp-plugin-loader] libide/lsp: implement diagnostic provider dynamic GType registration

[Christian Hergert <chergert src gnome org>]

commit 8d59bfdc75f9d6ca55c34fc5636b97f7dd688701
Author: Christian Hergert <chergert redhat com>
Date:   Thu Oct 13 18:13:58 2022 -0500

    libide/lsp: implement diagnostic provider dynamic GType registration

 .../lsp/ide-lsp-plugin-diagnostic-provider.c       | 100 +++++++++++++++++++++
 src/libide/lsp/ide-lsp-plugin-private.h            |   3 +
 src/libide/lsp/ide-lsp-plugin.c                    |  10 +--
 src/libide/lsp/meson.build                         |   1 +
 4 files changed, 105 insertions(+), 9 deletions(-)
---
diff --git a/src/libide/lsp/ide-lsp-plugin-diagnostic-provider.c 
b/src/libide/lsp/ide-lsp-plugin-diagnostic-provider.c
new file mode 100644
index 000000000..3eade89ad
--- /dev/null
+++ b/src/libide/lsp/ide-lsp-plugin-diagnostic-provider.c
@@ -0,0 +1,100 @@
+/* ide-lsp-plugin-diagnostic-provider.c
+ *
+ * Copyright 2022 Christian Hergert <chergert redhat com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+#define G_LOG_DOMAIN "ide-lsp-plugin-diagnostic-provider"
+
+#include "config.h"
+
+#include <libpeas/peas.h>
+
+#include <libide-code.h>
+
+#include "ide-lsp-diagnostic-provider.h"
+#include "ide-lsp-plugin-private.h"
+#include "ide-lsp-service.h"
+
+typedef struct _IdeLspPluginDiagnosticProviderClass
+{
+  IdeLspDiagnosticProviderClass  parent_class;
+  IdeLspPluginInfo              *info;
+} IdeLspPluginDiagnosticProviderClass;
+
+static void
+ide_lsp_plugin_diagnostic_provider_load (IdeDiagnosticProvider *provider)
+{
+  IdeLspPluginDiagnosticProviderClass *klass = (IdeLspPluginDiagnosticProviderClass *)(((GTypeInstance 
*)provider)->g_class);
+  g_autoptr(IdeLspServiceClass) service_class = g_type_class_ref (klass->info->service_type);
+
+  ide_lsp_service_class_bind_client (service_class, IDE_OBJECT (provider));
+}
+
+static void
+ide_lsp_plugin_diagnostic_provider_class_init (IdeLspPluginDiagnosticProviderClass *klass,
+                                               IdeLspPluginInfo                    *info)
+{
+  klass->info = info;
+}
+
+static void
+ide_lsp_plugin_diagnostic_provider_iface_init (IdeDiagnosticProviderInterface *iface)
+{
+  iface->load = ide_lsp_plugin_diagnostic_provider_load;
+}
+
+G_GNUC_BEGIN_IGNORE_DEPRECATIONS
+GObject *
+ide_lsp_plugin_create_diagnostic_provider (guint             n_parameters,
+                                           GParameter       *parameters,
+                                           IdeLspPluginInfo *info)
+{
+  ide_lsp_plugin_remove_plugin_info_param (&n_parameters, parameters);
+
+  if G_UNLIKELY (info->diagnostic_provider_type == G_TYPE_INVALID)
+    {
+      g_autofree char *name = g_strconcat (info->module_name, "+DiagnosticProvider", NULL);
+
+      info->diagnostic_provider_type =
+        g_type_register_static (IDE_TYPE_LSP_DIAGNOSTIC_PROVIDER,
+                                name,
+                                &(GTypeInfo) {
+                                  sizeof (IdeLspPluginDiagnosticProviderClass),
+                                  NULL,
+                                  NULL,
+                                  (GClassInitFunc)ide_lsp_plugin_diagnostic_provider_class_init,
+                                  NULL,
+                                  ide_lsp_plugin_info_ref (info),
+                                  sizeof (IdeLspDiagnosticProvider),
+                                  0,
+                                  NULL,
+                                  NULL,
+                                },
+                                G_TYPE_FLAG_FINAL);
+      g_type_add_interface_static (info->diagnostic_provider_type,
+                                   IDE_TYPE_DIAGNOSTIC_PROVIDER,
+                                   &(GInterfaceInfo) {
+                                     (GInterfaceInitFunc)(void (*) 
(void))ide_lsp_plugin_diagnostic_provider_iface_init,
+                                     NULL,
+                                     NULL,
+                                   });
+    }
+
+  return g_object_newv (info->diagnostic_provider_type, n_parameters, parameters);
+}
+G_GNUC_END_IGNORE_DEPRECATIONS
diff --git a/src/libide/lsp/ide-lsp-plugin-private.h b/src/libide/lsp/ide-lsp-plugin-private.h
index f2236dc46..375a66d45 100644
--- a/src/libide/lsp/ide-lsp-plugin-private.h
+++ b/src/libide/lsp/ide-lsp-plugin-private.h
@@ -46,6 +46,9 @@ void              ide_lsp_plugin_remove_plugin_info_param   (guint            *n
 GObject          *ide_lsp_plugin_create_completion_provider (guint             n_parameters,
                                                              GParameter       *parameters,
                                                              IdeLspPluginInfo *info);
+GObject          *ide_lsp_plugin_create_diagnostic_provider (guint             n_parameters,
+                                                             GParameter       *parameters,
+                                                             IdeLspPluginInfo *info);
 G_GNUC_END_IGNORE_DEPRECATIONS
 
 G_END_DECLS
diff --git a/src/libide/lsp/ide-lsp-plugin.c b/src/libide/lsp/ide-lsp-plugin.c
index fdcecb1f7..b8ce48a2f 100644
--- a/src/libide/lsp/ide-lsp-plugin.c
+++ b/src/libide/lsp/ide-lsp-plugin.c
@@ -199,14 +199,6 @@ ide_lsp_plugin_factory (IdeLspPluginInfo *info,
 }
 
 
-static GObject *
-ide_lsp_plugin_diagnostic_factory (guint       n_parameters,
-                                   GParameter *parameters,
-                                   gpointer    user_data)
-{
-  return ide_lsp_plugin_factory (user_data, IDE_TYPE_LSP_DIAGNOSTIC_PROVIDER, n_parameters, parameters);
-}
-
 static GObject *
 ide_lsp_plugin_symbol_resolver_factory (guint       n_parameters,
                                         GParameter *parameters,
@@ -283,7 +275,7 @@ ide_lsp_plugin_register (PeasObjectModule     *object_module,
   if ((features & IDE_LSP_PLUGIN_FEATURES_DIAGNOSTICS) != 0)
     peas_object_module_register_extension_factory (object_module,
                                                    IDE_TYPE_DIAGNOSTIC_PROVIDER,
-                                                   ide_lsp_plugin_diagnostic_factory,
+                                                   
(PeasFactoryFunc)ide_lsp_plugin_create_diagnostic_provider,
                                                    ide_lsp_plugin_info_ref (info),
                                                    (GDestroyNotify)ide_lsp_plugin_info_unref);
 
diff --git a/src/libide/lsp/meson.build b/src/libide/lsp/meson.build
index 3e769d2f9..7428c8ad8 100644
--- a/src/libide/lsp/meson.build
+++ b/src/libide/lsp/meson.build
@@ -57,6 +57,7 @@ libide_lsp_public_sources = [
   'ide-lsp-hover-provider.c',
   'ide-lsp-plugin.c',
   'ide-lsp-plugin-completion-provider.c',
+  'ide-lsp-plugin-diagnostic-provider.c',
   'ide-lsp-rename-provider.c',
   'ide-lsp-search-provider.c',
   'ide-lsp-search-result.c',