[libsoup/carlosgc/http2-io-error-uaf, : 1/2] http2: do not retry a message if connection never completed a request

[Carlos Garcia Campos <carlosgc src gnome org>]

commit 6be67842b7048060b14a7f2c1c12af6861343072
Author: Carlos Garcia Campos <cgarcia igalia com>
Date:   Thu Oct 13 11:12:36 2022 +0200

    http2: do not retry a message if connection never completed a request
    
    This is what we have always done in http1.

 libsoup/http2/soup-client-message-io-http2.c | 3 +++
 1 file changed, 3 insertions(+)
---
diff --git a/libsoup/http2/soup-client-message-io-http2.c b/libsoup/http2/soup-client-message-io-http2.c
index e45ce132..ca8eec5a 100644
--- a/libsoup/http2/soup-client-message-io-http2.c
+++ b/libsoup/http2/soup-client-message-io-http2.c
@@ -77,6 +77,7 @@ typedef struct {
         GTask *close_task;
         gboolean session_terminated;
         gboolean goaway_sent;
+        gboolean ever_used;
 
         guint in_callback;
 } SoupClientMessageIOHTTP2;
@@ -234,6 +235,7 @@ soup_http2_message_data_can_be_restarted (SoupHTTP2MessageData *data,
                 return TRUE;
 
         return data->state < STATE_READ_DATA_START &&
+                data->io->ever_used &&
                 !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_TIMED_OUT) &&
                 !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_WOULD_BLOCK) &&
                 !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED) &&
@@ -1563,6 +1565,7 @@ client_stream_eof (SoupClientInputStream *stream,
         h2_debug (io, data, "Client stream EOF");
         soup_message_set_metrics_timestamp (msg, SOUP_MESSAGE_METRICS_RESPONSE_END);
         advance_state_from (data, STATE_READ_DATA, STATE_READ_DONE);
+        io->ever_used = TRUE;
         g_signal_handlers_disconnect_by_func (stream, client_stream_eof, msg);
         soup_message_got_body (data->msg);
 }