[nautilus/wip/corey/selection-performance: 16/16] files-view: Optimize loop in update_selection_menu




commit 48b5f53bc1e42c24afbffadb893f0f0628d0317a
Author: Corey Berla <corey berla me>
Date:   Sat Oct 1 08:31:23 2022 -0700

    files-view: Optimize loop in update_selection_menu
    
    We only show certain items in the selection menu if all items
    support the operation.  If we are going to set a flag to false,
    don't perform the check if it's already false.

 src/nautilus-files-view.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index d60fed0d8..27bf871cc 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -8035,22 +8035,22 @@ update_selection_menu (NautilusFilesView *view)
 
         file = NAUTILUS_FILE (l->data);
 
-        if (!nautilus_mime_file_extracts (file))
+        if (show_extract && !nautilus_mime_file_extracts (file))
         {
             show_extract = FALSE;
         }
 
-        if (!nautilus_mime_file_opens_in_external_app (file))
+        if (show_app && !nautilus_mime_file_opens_in_external_app (file))
         {
             show_app = FALSE;
         }
 
-        if (!nautilus_mime_file_launches (file))
+        if (show_run && !nautilus_mime_file_launches (file))
         {
             show_run = FALSE;
         }
 
-        if (!nautilus_file_opens_in_view (file))
+        if (item_opens_in_view && !nautilus_file_opens_in_view (file))
         {
             item_opens_in_view = FALSE;
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]