[gnome-builder] plugins/buildui: move overview into seperate prefs group
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] plugins/buildui: move overview into seperate prefs group
- Date: Tue, 19 Jul 2022 19:14:48 +0000 (UTC)
commit 7b3c7044d18069ae49f5cef02476b5fe7cedbebe
Author: Christian Hergert <chergert redhat com>
Date: Tue Jul 19 12:14:42 2022 -0700
plugins/buildui: move overview into seperate prefs group
.../buildui/gbp-buildui-preferences-addin.c | 41 ++++++++++++++++------
1 file changed, 30 insertions(+), 11 deletions(-)
---
diff --git a/src/plugins/buildui/gbp-buildui-preferences-addin.c
b/src/plugins/buildui/gbp-buildui-preferences-addin.c
index 923eea3e4..5f5ff9260 100644
--- a/src/plugins/buildui/gbp-buildui-preferences-addin.c
+++ b/src/plugins/buildui/gbp-buildui-preferences-addin.c
@@ -224,18 +224,41 @@ add_runtiem_row (AdwPreferencesGroup *group,
adw_preferences_group_add (group, row);
}
+static void
+create_overview_widgetry (const char *page_name,
+ const IdePreferenceItemEntry *entry,
+ AdwPreferencesGroup *group,
+ gpointer user_data)
+{
+ g_autoptr(GFile) workdir = NULL;
+ IdeBuildSystem *build_system;
+ IdeContext *context;
+ IdeConfig *config = user_data;
+
+ g_assert (IDE_IS_MAIN_THREAD ());
+ g_assert (ADW_IS_PREFERENCES_GROUP (group));
+ g_assert (IDE_IS_CONFIG (config));
+ g_assert (page_name != NULL && g_str_equal (page_name, ide_config_get_id (config)));
+
+ context = ide_object_get_context (IDE_OBJECT (config));
+ workdir = ide_context_ref_workdir (context);
+ build_system = ide_build_system_from_context (context);
+
+ add_description_row (group, _("Name"), ide_config_get_display_name (config));
+ add_description_row (group, _("Source Directory"), g_file_peek_path (workdir));
+ add_description_row (group, _("Build System"), ide_build_system_get_display_name (build_system));
+}
+
static void
create_general_widgetry (const char *page_name,
const IdePreferenceItemEntry *entry,
AdwPreferencesGroup *group,
gpointer user_data)
{
- g_autoptr(GFile) workdir = NULL;
- IdeConfig *config = user_data;
- IdeConfigManager *config_manager;
- IdeBuildSystem *build_system;
IdeRuntimeManager *runtime_manager;
+ IdeConfigManager *config_manager;
IdeContext *context;
+ IdeConfig *config = user_data;
GtkWidget *box;
static const struct {
const gchar *label;
@@ -264,12 +287,6 @@ create_general_widgetry (const char *page_name,
g_assert (page_name != NULL && g_str_equal (page_name, ide_config_get_id (config)));
context = ide_object_get_context (IDE_OBJECT (config));
- build_system = ide_build_system_from_context (context);
- workdir = ide_context_ref_workdir (context);
-
- add_description_row (group, _("Name"), ide_config_get_display_name (config));
- add_description_row (group, _("Source Directory"), g_file_peek_path (workdir));
- add_description_row (group, _("Build System"), ide_build_system_get_display_name (build_system));
/* Translators: "Install" is a noun here */
add_entry_row (group, _("Install Prefix"), config, "prefix");
@@ -503,12 +520,14 @@ gbp_buildui_preferences_addin_load (IdePreferencesAddin *addin,
const char *page = ide_config_get_id (config);
const IdePreferenceGroupEntry groups[] = {
- { page, "general", 0, N_("General") },
+ { page, "overview", 0 },
+ { page, "general", 10, N_("General") },
{ page, "toolchain", 100, N_("Build Toolchain") },
{ page, "runtime", 200, N_("Application Runtime") },
};
const IdePreferenceItemEntry items[] = {
+ { page, "overview", "overview", 0, create_overview_widgetry },
{ page, "general", "general", 0, create_general_widgetry },
{ page, "toolchain", "toolchain", 100, create_toolchain_widgetry },
{ page, "runtime", "runtime", 200, create_runtime_widgetry },
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]