[gnome-software/1424-updates-page-clicking-os-updates-generates-runtime-warning] gs-update-dialog: Clicking OS Updates generates runtime warning



commit 475ed4922b541d7ee281858bdcd50e98094883d8
Author: Milan Crha <mcrha redhat com>
Date:   Thu Sep 9 19:26:29 2021 +0200

    gs-update-dialog: Clicking OS Updates generates runtime warning
    
    It's because the shown page can be either the app details page or
    the OS update page.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1424

 src/gs-update-dialog.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/src/gs-update-dialog.c b/src/gs-update-dialog.c
index a7e211c5d..c73d61d1d 100644
--- a/src/gs-update-dialog.c
+++ b/src/gs-update-dialog.c
@@ -313,7 +313,9 @@ gs_update_dialog_constructed (GObject *object)
                gs_update_dialog_show_update_details (dialog, dialog->app);
 
                child = hdy_deck_get_visible_child (HDY_DECK (dialog->deck));
-               gs_app_details_page_set_show_back_button (GS_APP_DETAILS_PAGE (child), FALSE);
+               /* It can be either the app details page or the OS update page */
+               if (GS_IS_APP_DETAILS_PAGE (child))
+                       gs_app_details_page_set_show_back_button (GS_APP_DETAILS_PAGE (child), FALSE);
        } else {
                gs_update_dialog_show_installed_updates (dialog);
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]