[gnome-music/wip/mschraal/view-styling-fixes: 12/16] Drop unneeded view CSS styling




commit 99c8f391a04feffeee79aafcac2619bbc7e797c8
Author: Marinus Schraal <mschraal gnome org>
Date:   Tue May 11 17:03:49 2021 +0200

    Drop unneeded view CSS styling
    
    Music used a homegrown content-view CSS style at places, which caused
    inconsistencies between views. In addition the regular view style seems
    to clash with mockups.
    
    Drop all custom and unneeded styling.

 data/org.gnome.Music.css |  2 --
 data/ui/AlbumWidget.ui   |  3 ---
 data/ui/AlbumsView.ui    |  6 +++---
 data/ui/SearchView.ui    | 12 ------------
 4 files changed, 3 insertions(+), 20 deletions(-)
---
diff --git a/data/org.gnome.Music.css b/data/org.gnome.Music.css
index 4659aec06..42e4915e1 100644
--- a/data/org.gnome.Music.css
+++ b/data/org.gnome.Music.css
@@ -129,8 +129,6 @@ box#ArtistAlbumsWidget .artist-label {
     transition: 100ms linear;
 }
 
-.content-view { background-color: @theme_bg; }
-
 .grey-image {
     color: alpha(@theme_fg_color, 0.3);
 }
diff --git a/data/ui/AlbumWidget.ui b/data/ui/AlbumWidget.ui
index cf1a153fc..04e5b2cc7 100644
--- a/data/ui/AlbumWidget.ui
+++ b/data/ui/AlbumWidget.ui
@@ -4,9 +4,6 @@
   <requires lib="gtk+" version="3.12"/>
   <template class="AlbumWidget" parent="GtkBox">
     <property name="visible">True</property>
-    <style>
-      <class name="view"/>
-    </style>
     <property name="can_focus">False</property>
     <child>
       <object class="GtkBox" id="albumInfo">
diff --git a/data/ui/AlbumsView.ui b/data/ui/AlbumsView.ui
index 78ad992e6..1ea3b8607 100644
--- a/data/ui/AlbumsView.ui
+++ b/data/ui/AlbumsView.ui
@@ -23,11 +23,11 @@
             <property name="valign">start</property>
             <property name="visible">True</property>
             <signal name="selected-children-changed" handler="_on_selected_children_changed" swapped="no"/>
-            <style>
-              <class name="content-view"/>
-            </style>
           </object>
         </child>
+        <style>
+          <class name="content-view"/>
+        </style>
       </object>
     </child>
   </template>
diff --git a/data/ui/SearchView.ui b/data/ui/SearchView.ui
index 52dca40f8..30075a624 100644
--- a/data/ui/SearchView.ui
+++ b/data/ui/SearchView.ui
@@ -77,9 +77,6 @@
                 <property name="valign">start</property>
                 <property name="visible">True</property>
                 <signal name="child-activated" handler="_on_artist_activated" swapped="no"/>
-                <style>
-                  <class name="content-view"/>
-                </style>
               </object>
             </child>
             <child>
@@ -130,9 +127,6 @@
                 <property name="selection_mode">none</property>
                 <property name="visible">True</property>
                 <signal name="child-activated" handler="_on_album_activated" swapped="no"/>
-                <style>
-                  <class name="content-view"/>
-                </style>
               </object>
             </child>
             <child>
@@ -200,9 +194,6 @@
                 <property name="selection-mode">none</property>
                 <property name="valign">start</property>
                 <signal name="child-activated" handler="_on_artist_activated" swapped="no"/>
-                <style>
-                  <class name="content-view"/>
-                </style>
               </object>
             </child>
             <child>
@@ -222,9 +213,6 @@
                 <property name="selection_mode">none</property>
                 <property name="visible">True</property>
                 <signal name="child-activated" handler="_on_album_activated" swapped="no"/>
-                <style>
-                  <class name="content-view"/>
-                </style>
               </object>
             </child>
           </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]