[mutter] display: Don't include sn.h from display-private.h



commit 2712555c7178ace33cfdf809537aa4f567994ecc
Author: Jonas Ã…dahl <jadahl gmail com>
Date:   Tue Mar 2 21:40:13 2021 +0100

    display: Don't include sn.h from display-private.h
    
    It has some annoying macro requirement to not nag about API stability;
    try to limit its exposure.
    
    Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1861>

 src/core/display-private.h              | 4 ----
 src/tests/test-utils.c                  | 1 +
 src/x11/meta-startup-notification-x11.c | 1 +
 3 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/core/display-private.h b/src/core/display-private.h
index 6008de05fe..220fd4da03 100644
--- a/src/core/display-private.h
+++ b/src/core/display-private.h
@@ -31,10 +31,6 @@
 #include <X11/extensions/sync.h>
 #include <X11/Xlib.h>
 
-#ifdef HAVE_STARTUP_NOTIFICATION
-#include <libsn/sn.h>
-#endif
-
 #include "clutter/clutter.h"
 #include "core/keybindings-private.h"
 #include "core/meta-gesture-tracker-private.h"
diff --git a/src/tests/test-utils.c b/src/tests/test-utils.c
index 0f4c165103..b0e7022c23 100644
--- a/src/tests/test-utils.c
+++ b/src/tests/test-utils.c
@@ -23,6 +23,7 @@
 
 #include <gio/gio.h>
 #include <string.h>
+#include <X11/Xlib-xcb.h>
 
 #include "core/display-private.h"
 #include "core/window-private.h"
diff --git a/src/x11/meta-startup-notification-x11.c b/src/x11/meta-startup-notification-x11.c
index 70aa2ac0fe..42be6d580f 100644
--- a/src/x11/meta-startup-notification-x11.c
+++ b/src/x11/meta-startup-notification-x11.c
@@ -20,6 +20,7 @@
 #include "meta-startup-notification-x11.h"
 
 #include <gio/gdesktopappinfo.h>
+#include <libsn/sn.h>
 
 #include "core/display-private.h"
 #include "core/startup-notification-private.h"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]