[gnome-builder/gnome-builder-3-40] flatpak: propagate task errors in bootstrap
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/gnome-builder-3-40] flatpak: propagate task errors in bootstrap
- Date: Sun, 25 Apr 2021 00:02:26 +0000 (UTC)
commit 8b5c5c13194697655faa9496895698d23f99cc24
Author: Christian Hergert <chergert redhat com>
Date: Sat Apr 3 13:41:58 2021 -0700
flatpak: propagate task errors in bootstrap
We can get into an infinite (albeit async via user-flow) state if the
downloads fail and pipeline reloads.
This only invalidates the pipeline if the task was successful.
Related #1430
src/plugins/flatpak/gbp-flatpak-runtime-provider.c | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
b/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
index 49a7211a8..44155cb83 100644
--- a/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
+++ b/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
@@ -641,6 +641,8 @@ gbp_flatpak_runtime_provider_bootstrap_install_cb (GObject *object,
if (!ide_task_had_error (task) && state->count == 0)
gbp_flatpak_runtime_provider_bootstrap_complete (task);
+ else if (!ide_task_had_error (task))
+ ide_task_return_error (task, g_steal_pointer (&error));
}
static gchar *
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]