[vala/staging] vala: Issue warning when passing arrays to typeof(), except for "string[]"



commit 8e91efb95498318e38a43877e26d401c11a897f2
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Wed Oct 23 14:21:49 2019 +0200

    vala: Issue warning when passing arrays to typeof(), except for "string[]"
    
    Passing arrays resolve to G_TYPE_INVALID, and "string[]" to G_TYPE_STRV
    
    See https://gitlab.gnome.org/GNOME/vala/issues/868

 vala/valatypeofexpression.vala | 4 ++++
 1 file changed, 4 insertions(+)
---
diff --git a/vala/valatypeofexpression.vala b/vala/valatypeofexpression.vala
index 5aa28e1fd..b63368100 100644
--- a/vala/valatypeofexpression.vala
+++ b/vala/valatypeofexpression.vala
@@ -86,6 +86,10 @@ public class Vala.TypeofExpression : Expression {
                        Report.warning (_data_type.source_reference, "Type argument list without effect");
                }
 
+               if (_data_type is ArrayType && ((ArrayType) _data_type).element_type.type_symbol != 
context.analyzer.string_type.type_symbol) {
+                       Report.warning (_data_type.source_reference, "Arrays do not have a `GLib.Type', with 
the exception of `string[]'");
+               }
+
                return !error;
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]