[gnome-shell/wip/fmuellner/remove-user-icon-frame: 10/10] userWidget: Remove frame around avatar



commit 31a9729592682d6d92113a19fa3035787bba4bbc
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Feb 5 17:28:41 2019 +0100

    userWidget: Remove frame around avatar
    
    There's a push for round user images, for which the existing square
    frame is a bad match. So remove the frame and enforce the shape.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/811

 data/theme/gnome-shell-sass/_common.scss | 11 ++++-------
 js/ui/userWidget.js                      |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/_common.scss b/data/theme/gnome-shell-sass/_common.scss
index 44bf04ec3..5bfc0628b 100644
--- a/data/theme/gnome-shell-sass/_common.scss
+++ b/data/theme/gnome-shell-sass/_common.scss
@@ -267,8 +267,7 @@ StScrollBar {
   }
 
   .end-session-dialog-logout-icon {
-    //border: 2px solid #8b8b8b;
-    border-radius: 5px;
+    border-radius: 99px;
     width: 48px;
     height: 48px;
     background-size: contain;
@@ -428,7 +427,7 @@ StScrollBar {
   }
 
   .polkit-dialog-user-icon {
-    border-radius: 5px;
+    border-radius: 99px;
     background-size: contain;
     width: 48px;
     height: 48px;
@@ -1754,13 +1753,11 @@ StScrollBar {
 
 /* Auth Dialogs & Screen Shield */
 
-.framed-user-icon {
+.user-icon {
   background-size: contain;
-  border: 2px solid $osd_fg_color;
   color: $osd_fg_color;
-  border-radius: 3px;
+  border-radius: 99px;
   &:hover {
-    border-color: lighten($osd_fg_color,30%);
     color: lighten($osd_fg_color,30%);
   }
 }
diff --git a/js/ui/userWidget.js b/js/ui/userWidget.js
index 5daf5e73d..a3bf4cba1 100644
--- a/js/ui/userWidget.js
+++ b/js/ui/userWidget.js
@@ -18,7 +18,7 @@ var Avatar = class {
         this._user = user;
         params = Params.parse(params, { reactive: false,
                                         iconSize: AVATAR_ICON_SIZE,
-                                        styleClass: 'framed-user-icon' });
+                                        styleClass: 'user-icon' });
         this._iconSize = params.iconSize;
 
         let scaleFactor = St.ThemeContext.get_for_stage(global.stage).scale_factor;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]