[gnome-shell/wip/snwh/sass-cleanup] theme: improve some border drawing

[Sam Hewitt <snwh src gnome org>]

commit bd34aee5754b2c83eb23f03047d4e6b238adf53a
Author: Sam Hewitt <sam snwh org>
Date:   Tue Dec 17 09:13:26 2019 -0500

    theme: improve some border drawing

 data/theme/gnome-shell-sass/_drawing.scss          | 7 +++----
 data/theme/gnome-shell-sass/widgets/_popovers.scss | 2 +-
 data/theme/gnome-shell-sass/widgets/_slider.scss   | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/_drawing.scss b/data/theme/gnome-shell-sass/_drawing.scss
index 0565474b30..7331020af3 100644
--- a/data/theme/gnome-shell-sass/_drawing.scss
+++ b/data/theme/gnome-shell-sass/_drawing.scss
@@ -61,8 +61,7 @@
        //
        // colored buttons want the border form the base color
        //
-       // @return if($variant == 'light', darken($c, 18%), darken($c, 8%));
-       @return if($variant == 'light', darken($c, 13%), lighten($c, 7%));
+       @return if($variant == 'light', darken($c, 18%), darken($c, 4%));
 }
 
 @function draw_text_shadow_color ($tc:$fg_color, $bg:$bg_color) {
@@ -156,10 +155,10 @@
        // hover osd button
        @else if $t==hover {
                color: $tc;
-               background-color: lighten($c,5%) !important;
+               background-color: lighten($c, if($variant == 'light', 8%, 5%)) !important;
                border-width: 1px;
                border-style: solid;
-               border-color: draw_border_color(lighten($c,5%));
+               border-color: if($variant == 'light', draw_border_color(lighten($c, 7%)), 
draw_border_color($c));
                @include draw_shadows(0 1px 1px 0 $shadow_color);
                text-shadow: 0 1px $text_shadow_color;
                icon-shadow: 0 1px $text_shadow_color;
diff --git a/data/theme/gnome-shell-sass/widgets/_popovers.scss 
b/data/theme/gnome-shell-sass/widgets/_popovers.scss
index ad084596df..202d0eda35 100644
--- a/data/theme/gnome-shell-sass/widgets/_popovers.scss
+++ b/data/theme/gnome-shell-sass/widgets/_popovers.scss
@@ -8,7 +8,7 @@ $popover_arrow_height: 12px;
        -arrow-border-radius: $base_border_radius+4;
        -arrow-background-color: $bg_color;
        -arrow-border-width: 1px;
-       -arrow-border-color: lighten($osd_outer_borders_color, 4%);
+       -arrow-border-color: $osd_borders_color;
        -arrow-base: $popover_arrow_height * 2;
        -arrow-rise: $popover_arrow_height;
        -arrow-box-shadow: 0 1px 3px rgba(0,0,0,0.5); // dreaming bugzilla #689995
diff --git a/data/theme/gnome-shell-sass/widgets/_slider.scss 
b/data/theme/gnome-shell-sass/widgets/_slider.scss
index f6e2eb7fc5..4b84ad60fa 100644
--- a/data/theme/gnome-shell-sass/widgets/_slider.scss
+++ b/data/theme/gnome-shell-sass/widgets/_slider.scss
@@ -17,9 +17,9 @@ $slider_size: 15px;
        -barlevel-overdrive-border-color: if($variant == 'light', darken($destructive_color, 4%), 
lighten($destructive_color, 2%)); //trough border when red;
        -barlevel-overdrive-separator-width:1px;
        // slider hander
-       -slider-handle-radius: $slider_size * 0.5; // half the size of the 
+       -slider-handle-radius: $slider_size * 0.5; // half the size of the size
        -slider-handle-border-width: 1px;
-       -slider-handle-border-color: if($variant == 'light', $borders_color, $fg_color); //active trough 
border
+       -slider-handle-border-color: if($variant == 'light', $borders_color, $fg_color);
 
        color: if($variant == 'light', lighten($bg_color, 10%), $fg_color);
        &:hover { color: $hover_bg_color; }