[gnome-builder] file: use ide_file_new instead of g_object_new



commit 80a36415258433b3c6c154286a9a835cad2729cc
Author: Christian Hergert <chergert redhat com>
Date:   Sat Jan 13 03:01:25 2018 -0800

    file: use ide_file_new instead of g_object_new
    
    This gives us the opportunity to use a cached file instance instead of
    always creating a new one.

 src/libide/diagnostics/ide-diagnostics-manager.c | 5 +----
 src/libide/editor/ide-editor-workbench-addin.c   | 5 +----
 src/libide/langserv/ide-langserv-client.c        | 8 ++++----
 3 files changed, 6 insertions(+), 12 deletions(-)
---
diff --git a/src/libide/diagnostics/ide-diagnostics-manager.c 
b/src/libide/diagnostics/ide-diagnostics-manager.c
index d4ab41cb1..36943c571 100644
--- a/src/libide/diagnostics/ide-diagnostics-manager.c
+++ b/src/libide/diagnostics/ide-diagnostics-manager.c
@@ -437,10 +437,7 @@ ide_diagnostics_group_diagnose_foreach (IdeExtensionSetAdapter *adapter,
 
   context = ide_object_get_context (IDE_OBJECT (self));
 
-  file = g_object_new (IDE_TYPE_FILE,
-                       "context", context,
-                       "file", group->file,
-                       NULL);
+  file = ide_file_new (context, group->file);
 
 #ifdef IDE_ENABLE_TRACE
   {
diff --git a/src/libide/editor/ide-editor-workbench-addin.c b/src/libide/editor/ide-editor-workbench-addin.c
index 361b29a3f..0f874bdac 100644
--- a/src/libide/editor/ide-editor-workbench-addin.c
+++ b/src/libide/editor/ide-editor-workbench-addin.c
@@ -416,10 +416,7 @@ ide_editor_workbench_addin_open_async (IdeWorkbenchAddin    *addin,
       return;
     }
 
-  ifile = g_object_new (IDE_TYPE_FILE,
-                        "context", context,
-                        "file", gfile,
-                        NULL);
+  ifile = ide_file_new (context, gfile);
 
   ide_buffer_manager_load_file_async (buffer_manager,
                                       ifile,
diff --git a/src/libide/langserv/ide-langserv-client.c b/src/libide/langserv/ide-langserv-client.c
index da281e747..97d082f91 100644
--- a/src/libide/langserv/ide-langserv-client.c
+++ b/src/libide/langserv/ide-langserv-client.c
@@ -587,12 +587,12 @@ ide_langserv_client_text_document_publish_diagnostics (IdeLangservClient *self,
       g_autoptr(IdeFile) ifile = NULL;
       g_autoptr(GFile) file = NULL;
       g_autoptr(IdeDiagnostics) diagnostics = NULL;
+      IdeContext *context;
 
+      context = ide_object_get_context (IDE_OBJECT (self));
       file = g_file_new_for_uri (uri);
-      ifile = g_object_new (IDE_TYPE_FILE,
-                            "file", file,
-                            "context", ide_object_get_context (IDE_OBJECT (self)),
-                            NULL);
+      ifile = ide_file_new (context, file);
+
       diagnostics = ide_langserv_client_translate_diagnostics (self, ifile, json_diagnostics);
 
       IDE_TRACE_MSG ("%"G_GSIZE_FORMAT" diagnostics received for %s",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]