[gnome-software/wip/kalev/category-tile-revert] category page: Revert back to using SummaryTiles
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/kalev/category-tile-revert] category page: Revert back to using SummaryTiles
- Date: Wed, 21 Feb 2018 23:09:29 +0000 (UTC)
commit ed5d96b2828a46312ff54f5c233f792edac33131
Author: Kalev Lember <klember redhat com>
Date: Thu Feb 22 00:00:14 2018 +0100
category page: Revert back to using SummaryTiles
We need further work on the tiles used in the category page to make sure
they look good and are usable. Right now we lose too much information
with PopularTiles, e.g. all tiles in the codec list show up as
"GStreamer Mul..." with no way to distinguish between them.
This commit switches back to using SummaryTiles that provide more
information.
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups-software/master/wireframes/app-tiles.png
provides guidance how we should evolve with the tiles in the future.
src/gs-category-page.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/src/gs-category-page.c b/src/gs-category-page.c
index 03957c67..af51c0fd 100644
--- a/src/gs-category-page.c
+++ b/src/gs-category-page.c
@@ -150,11 +150,7 @@ gs_category_page_get_apps_cb (GObject *source_object,
for (i = 0; i < gs_app_list_length (list); i++) {
app = gs_app_list_index (list, i);
- tile = gs_popular_tile_new (app);
- if (!gs_app_has_quirk (app, AS_APP_QUIRK_PROVENANCE) ||
- gs_utils_list_has_app_fuzzy (list, app))
- gs_popular_tile_show_source (GS_POPULAR_TILE (tile), TRUE);
-
+ tile = gs_summary_tile_new (app);
g_signal_connect (tile, "clicked",
G_CALLBACK (app_tile_clicked), self);
gtk_container_add (GTK_CONTAINER (self->category_detail_box), tile);
@@ -361,7 +357,7 @@ gs_category_page_reload (GsPage *page)
count = MIN(30, gs_category_get_size (self->subcategory));
for (i = 0; i < count; i++) {
- tile = gs_popular_tile_new (NULL);
+ tile = gs_summary_tile_new (NULL);
gtk_container_add (GTK_CONTAINER (self->category_detail_box), tile);
gtk_widget_set_can_focus (gtk_widget_get_parent (tile), FALSE);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]