[vala/staging] vala: Make SemanticAnalyzer.check_arguments() independent of context



commit 3b2e2d5a0847b903c7a4b73a41bba49acd5de8da
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Sun Feb 18 23:02:23 2018 +0100

    vala: Make SemanticAnalyzer.check_arguments() independent of context

 vala/valamethodcall.vala               |    4 ++++
 vala/valaobjectcreationexpression.vala |    4 ++++
 vala/valasemanticanalyzer.vala         |    4 ----
 3 files changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/vala/valamethodcall.vala b/vala/valamethodcall.vala
index 76f2403..415191a 100644
--- a/vala/valamethodcall.vala
+++ b/vala/valamethodcall.vala
@@ -371,6 +371,10 @@ public class Vala.MethodCall : Expression {
                var args = get_argument_list ();
                Iterator<Expression> arg_it = args.iterator ();
                foreach (Parameter param in params) {
+                       if (!param.check (context)) {
+                               error = true;
+                       }
+
                        if (param.ellipsis) {
                                break;
                        }
diff --git a/vala/valaobjectcreationexpression.vala b/vala/valaobjectcreationexpression.vala
index e203a1a..7a2d6fb 100644
--- a/vala/valaobjectcreationexpression.vala
+++ b/vala/valaobjectcreationexpression.vala
@@ -367,6 +367,10 @@ public class Vala.ObjectCreationExpression : Expression {
                        var args = get_argument_list ();
                        Iterator<Expression> arg_it = args.iterator ();
                        foreach (Parameter param in m.get_parameters ()) {
+                               if (!param.check (context)) {
+                                       error = true;
+                               }
+
                                if (param.ellipsis) {
                                        break;
                                }
diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index a0535ad..ddf6f28 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -408,10 +408,6 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
                bool ellipsis = false;
                int i = 0;
                foreach (Parameter param in params) {
-                       if (!param.check (context)) {
-                               return false;
-                       }
-
                        if (param.ellipsis) {
                                ellipsis = true;
                                break;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]