[gnome-software] Revert "snap: Show revision number in version field"



commit d729c758ccb9e4edc3bc382fa0f8acd70cbc5495
Author: Robert Ancell <robert ancell canonical com>
Date:   Thu Feb 15 14:12:19 2018 +1300

    Revert "snap: Show revision number in version field"
    
    This reverts commit f332167b104aa001739affe5199e6610d5db1476.
    
    While this is what the command line tool does I'm not convinced it makes sense
    to GNOME Software users.

 plugins/snap/gs-plugin-snap.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
---
diff --git a/plugins/snap/gs-plugin-snap.c b/plugins/snap/gs-plugin-snap.c
index ee117204..8c022805 100644
--- a/plugins/snap/gs-plugin-snap.c
+++ b/plugins/snap/gs-plugin-snap.c
@@ -760,8 +760,6 @@ gs_plugin_refine_app (GsPlugin *plugin,
        if (local_snap != NULL) {
                const gchar *name;
                g_autofree gchar *description = NULL;
-               g_autofree gchar *version = NULL;
-
                if (gs_app_get_state (app) == AS_APP_STATE_UNKNOWN)
                        gs_app_set_state (app, AS_APP_STATE_INSTALLED);
                name = snapd_snap_get_title (local_snap);
@@ -773,8 +771,7 @@ gs_plugin_refine_app (GsPlugin *plugin,
                if (description != NULL)
                        gs_app_set_description (app, GS_APP_QUALITY_NORMAL, description);
                gs_app_set_license (app, GS_APP_QUALITY_NORMAL, snapd_snap_get_license (local_snap));
-               version = g_strdup_printf ("%s (%s)", snapd_snap_get_version (local_snap), 
snapd_snap_get_revision (local_snap));
-               gs_app_set_version (app, version);
+               gs_app_set_version (app, snapd_snap_get_version (local_snap));
                gs_app_set_size_installed (app, snapd_snap_get_installed_size (local_snap));
                gs_app_set_install_date (app, g_date_time_to_unix (snapd_snap_get_install_date (local_snap)));
                gs_app_set_developer_name (app, snapd_snap_get_developer (local_snap));
@@ -804,11 +801,7 @@ gs_plugin_refine_app (GsPlugin *plugin,
                if (description != NULL)
                        gs_app_set_description (app, GS_APP_QUALITY_NORMAL, description);
                gs_app_set_license (app, GS_APP_QUALITY_NORMAL, snapd_snap_get_license (store_snap));
-               if (gs_app_get_version (app) == NULL) {
-                       g_autofree gchar *version = NULL;
-                       version = g_strdup_printf ("%s (%s)", snapd_snap_get_version (store_snap), 
snapd_snap_get_revision (store_snap));
-                       gs_app_set_version (app, version);
-               }
+               gs_app_set_version (app, snapd_snap_get_version (store_snap));
                gs_app_set_size_download (app, snapd_snap_get_download_size (store_snap));
                gs_app_set_developer_name (app, snapd_snap_get_developer (store_snap));
                if (icon_url == NULL) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]