[gtk: 1/2] gdk_x11_display_get_monitor: fix monitor number test logic



commit bb8debe92589285b26b4b77202e66d00631081c7
Author: Sébastien Villemot <sebastien debian org>
Date:   Mon Apr 9 15:36:36 2018 +0200

    gdk_x11_display_get_monitor: fix monitor number test logic
    
    When asked for a nonexistent (positive) monitor number,
    gdk_x11_display_get_monitor would (at best) return an uninitialized pointer,
    instead of returning NULL.

 gdk/x11/gdkdisplay-x11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gdk/x11/gdkdisplay-x11.c b/gdk/x11/gdkdisplay-x11.c
index 1386acbb49..15dd1a5a5f 100644
--- a/gdk/x11/gdkdisplay-x11.c
+++ b/gdk/x11/gdkdisplay-x11.c
@@ -2951,7 +2951,7 @@ gdk_x11_display_get_monitor (GdkDisplay *display,
 {
   GdkX11Display *x11_display = GDK_X11_DISPLAY (display);
 
-  if (0 <= monitor_num || monitor_num < x11_display->monitors->len)
+  if (0 <= monitor_num && monitor_num < x11_display->monitors->len)
     return (GdkMonitor *)x11_display->monitors->pdata[monitor_num];
 
   return NULL;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]