[meld] windowstate: Don't re-read window state from settings after first load



commit 491d6d07d15a6246d443908256f6c4cdbf3ecd0d
Author: Kai Willadsen <kai willadsen gmail com>
Date:   Fri Mar 31 06:41:20 2017 +1000

    windowstate: Don't re-read window state from settings after first load
    
    This is part of trying to address an infinite re-allocation cycle.
    Since we really don't care about resizing our window from the settings
    state anyway, this seems like a low-cost win.

 meld/windowstate.py |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/meld/windowstate.py b/meld/windowstate.py
index baf7d98..d1846ac 100644
--- a/meld/windowstate.py
+++ b/meld/windowstate.py
@@ -40,7 +40,12 @@ class SavedWindowState(GObject.GObject):
         window.connect('size-allocate', self.on_size_allocate)
         window.connect('window-state-event', self.on_window_state_event)
 
-        bind_flags = Gio.SettingsBindFlags.DEFAULT
+        # Don't re-read from gsettings after initialisation; we've seen
+        # what looked like issues with buggy debounce here.
+        bind_flags = (
+            Gio.SettingsBindFlags.DEFAULT |
+            Gio.SettingsBindFlags.GET_NO_CHANGES
+        )
         self.settings = load_settings_schema(WINDOW_STATE_SCHEMA)
         self.settings.bind('width', self, 'width', bind_flags)
         self.settings.bind('height', self, 'height', bind_flags)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]