[gnome-dictionary] Silence compiler warnings about unused variables
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-dictionary] Silence compiler warnings about unused variables
- Date: Tue, 11 Apr 2017 21:55:29 +0000 (UTC)
commit b5833c0e75a7d7f1e67c87aadacde1277ec4d214
Author: Emmanuele Bassi <ebassi gnome org>
Date: Tue Apr 11 11:23:41 2017 +0100
Silence compiler warnings about unused variables
libgdict/gdict-database-chooser-button.c | 8 ++++----
libgdict/gdict-defbox.c | 6 +++---
libgdict/gdict-utils.c | 6 +-----
3 files changed, 8 insertions(+), 12 deletions(-)
---
diff --git a/libgdict/gdict-database-chooser-button.c b/libgdict/gdict-database-chooser-button.c
index e9efa63..fbdb191 100644
--- a/libgdict/gdict-database-chooser-button.c
+++ b/libgdict/gdict-database-chooser-button.c
@@ -313,11 +313,12 @@ gdict_database_chooser_button_clicked (GtkButton *button)
if (active && !priv->is_loaded)
{
+ context = gdict_database_chooser_get_context (GDICT_DATABASE_CHOOSER (priv->db_chooser));
+
gtk_stack_set_visible_child_name (GTK_STACK (priv->stack), "spinner");
- if (!priv->start_id)
+ if (priv->start_id == 0)
{
- context = gdict_database_chooser_get_context (GDICT_DATABASE_CHOOSER (priv->db_chooser));
priv->start_id = g_signal_connect (context, "database-lookup-start",
G_CALLBACK (lookup_start_cb),
chooser_button);
@@ -326,7 +327,7 @@ gdict_database_chooser_button_clicked (GtkButton *button)
chooser_button);
}
- if (!priv->error_id)
+ if (priv->error_id == 0)
priv->error_id = g_signal_connect (context, "error",
G_CALLBACK (error_cb),
chooser_button);
@@ -697,7 +698,6 @@ gdict_database_chooser_button_set_current_database (GdictDatabaseChooserButton *
{
GdictDatabaseChooserButtonPrivate *priv =
gdict_database_chooser_button_get_instance_private (chooser);
- gboolean valid;
g_return_val_if_fail (GDICT_IS_DATABASE_CHOOSER_BUTTON (chooser), FALSE);
diff --git a/libgdict/gdict-defbox.c b/libgdict/gdict-defbox.c
index 8d623be..4f07868 100644
--- a/libgdict/gdict-defbox.c
+++ b/libgdict/gdict-defbox.c
@@ -1091,7 +1091,7 @@ find_prev_clicked_cb (GtkWidget *widget,
GdictDefbox *defbox = GDICT_DEFBOX (user_data);
GdictDefboxPrivate *priv = defbox->priv;
const gchar *text;
- gboolean found;
+ gboolean found G_GNUC_UNUSED;
text = gtk_entry_get_text (GTK_ENTRY (priv->find_entry));
if (!text)
@@ -1173,7 +1173,7 @@ find_next_clicked_cb (GtkWidget *widget,
GdictDefbox *defbox = GDICT_DEFBOX (user_data);
GdictDefboxPrivate *priv = defbox->priv;
const gchar *text;
- gboolean found;
+ gboolean found G_GNUC_UNUSED;
text = gtk_entry_get_text (GTK_ENTRY (priv->find_entry));
if (!text)
@@ -1195,7 +1195,7 @@ find_entry_changed_cb (GtkWidget *widget,
GdictDefbox *defbox = GDICT_DEFBOX (user_data);
GdictDefboxPrivate *priv = defbox->priv;
gchar *text;
- gboolean found;
+ gboolean found G_GNUC_UNUSED;
text = gtk_editable_get_chars (GTK_EDITABLE (widget), 0, -1);
if (!text)
diff --git a/libgdict/gdict-utils.c b/libgdict/gdict-utils.c
index cc33772..45a9ffd 100644
--- a/libgdict/gdict-utils.c
+++ b/libgdict/gdict-utils.c
@@ -106,13 +106,11 @@ pre_parse_hook (GOptionContext *context,
gpointer data,
GError **error)
{
- const char *env_string;
-
if (gdict_is_initialized)
return TRUE;
#ifdef GDICT_ENABLE_DEBUG
- env_string = g_getenv ("GDICT_DEBUG");
+ const char *env_string = g_getenv ("GDICT_DEBUG");
if (env_string != NULL)
{
gdict_debug_flags =
@@ -120,8 +118,6 @@ pre_parse_hook (GOptionContext *context,
gdict_debug_keys,
G_N_ELEMENTS (gdict_debug_keys));
}
-#else
- env_string = NULL;
#endif /* GDICT_ENABLE_DEBUG */
return TRUE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]