[pitivi] Minor fixes to the error calls



commit 7303d0bfbe595ce8b3bb5dae816498c9b35c32a3
Author: Alexandru Băluț <alexandru balut gmail com>
Date:   Wed Dec 7 15:41:37 2016 +0100

    Minor fixes to the error calls
    
    Reviewed-by: Thibault Saunier <tsaunier gnome org>
    Differential Revision: https://phabricator.freedesktop.org/D1549

 pitivi/timeline/previewers.py |    4 ++--
 pitivi/timeline/timeline.py   |    2 --
 pitivi/utils/pipeline.py      |    4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)
---
diff --git a/pitivi/timeline/previewers.py b/pitivi/timeline/previewers.py
index c1975ef..c7bc4f6 100644
--- a/pitivi/timeline/previewers.py
+++ b/pitivi/timeline/previewers.py
@@ -1050,8 +1050,8 @@ class AudioPreviewer(Previewer, Zoomable, Loggable):
                 Gst.debug_bin_to_dot_file_with_ts(self.pipeline,
                                                   Gst.DebugGraphDetails.ALL,
                                                   "error-generating-waveforms")
-                self.error("Issue during waveforms generation: %s"
-                           "Abandonning", message.parse_error())
+                self.error("Aborting due to waveforms generation issue: %s",
+                           message.parse_error())
 
         elif message.type == Gst.MessageType.STATE_CHANGED:
             prev, new, unused_pending_state = message.parse_state_changed()
diff --git a/pitivi/timeline/timeline.py b/pitivi/timeline/timeline.py
index a733bcc..d19d865 100644
--- a/pitivi/timeline/timeline.py
+++ b/pitivi/timeline/timeline.py
@@ -1658,8 +1658,6 @@ class TimelineContainer(Gtk.Grid, Zoomable, Loggable):
 
     def _alignSelectedCb(self, unused_action, unused_parameter):
         if not self.ges_timeline:
-            self.error(
-                "Trying to use the autoalign feature with an empty timeline")
             return
 
         progress_dialog = AlignmentProgressDialog(self.app)
diff --git a/pitivi/utils/pipeline.py b/pitivi/utils/pipeline.py
index f0b42c3..5c8f7b6 100644
--- a/pitivi/utils/pipeline.py
+++ b/pitivi/utils/pipeline.py
@@ -381,7 +381,7 @@ class SimplePipeline(GObject.Object, Loggable):
                         if self._attempted_recoveries == MAX_RECOVERIES:
                             self._recovery_state = self.RecoveryState.NOT_RECOVERING
                             self._attempted_recoveries = 0
-                            self.error("Too many tries to seek back to right position"
+                            self.error("Too many tries to seek back to right position, "
                                        "not trying again, and going back to 0 instead")
                         else:
                             self._recovery_state = self.RecoveryState.SEEKED_AFTER_RECOVERING
@@ -472,7 +472,7 @@ class SimplePipeline(GObject.Object, Loggable):
         return False
 
     def _handleErrorMessage(self, error, detail, source):
-        self.error("error from %s: %s (%s)" % (source, error, detail))
+        self.error("error from %s: %s (%s)", source, error, detail)
         self.emit('error', error.message, detail)
 
     def _getDuration(self):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]