[gnome-shell] Revert "browser-plugin: try to avoid a crash"



commit cdba8e5cea313f43d479982ce9ec8bbb8c87281c
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Sat Nov 7 08:09:11 2015 -0600

    Revert "browser-plugin: try to avoid a crash"
    
    This reverts commit faae1a028e1bd3e6f6f078f2ed523a41787a17d5.

 browser-plugin/browser-plugin.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
---
diff --git a/browser-plugin/browser-plugin.c b/browser-plugin/browser-plugin.c
index ab6935d..46dacae 100644
--- a/browser-plugin/browser-plugin.c
+++ b/browser-plugin/browser-plugin.c
@@ -282,14 +282,6 @@ on_shell_signal (GDBusProxy *proxy,
 {
   PluginObject *obj = user_data;
 
-  /* FIXME: We have half a dozen bug reports in which this function crashes in
-   * WebKit due to a null NPObject. This should never happen, but since it is
-   * happening, let's turn the crash into a critical.
-   *
-   * https://bugzilla.gnome.org/show_bug.cgi?id=737932
-   */
-  g_return_if_fail (obj->instance);
-
   if (strcmp (signal_name, "ExtensionStatusChanged") == 0)
     {
       gchar *uuid;
@@ -320,12 +312,6 @@ on_shell_appeared (GDBusConnection *connection,
 {
   PluginObject *obj = (PluginObject*) user_data;
 
-  /* FIXME: Not sure if this is ever hit or not, but let's play it safe.
-   *
-   * https://bugzilla.gnome.org/show_bug.cgi?id=737932
-   */
-  g_return_if_fail (obj->instance);
-
   if (obj->restart_listener)
     {
       NPVariant result = { NPVariantType_Void };


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]