[goffice] Compilation: fix clang compilation a a few warnings.



commit 9e371e26d3f7835d5e6111adbbdb9c8fc0abe4ad
Author: Morten Welinder <terra gnome org>
Date:   Sun May 17 19:41:33 2015 -0400

    Compilation: fix clang compilation a a few warnings.

 ChangeLog                 |    6 ++++++
 configure.ac              |    2 +-
 goffice/utils/go-format.c |    4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 0a5a4ce..27316a7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2015-05-17  Morten Welinder  <terra gnome org>
 
+       * goffice/utils/go-format.c (go_format_output_simple_to_odf):
+       Taking a wild guess that result should have been initialized to
+       TRUE.
+
+       * configure.ac (set_more_warnings): clang fix from gnumeric.
+
        * goffice/math/go-quad.c (go_quad_start): Initialize constants via
        non-const objects.  See bug #749463.
 
diff --git a/configure.ac b/configure.ac
index 2e4ff67..91503ed 100644
--- a/configure.ac
+++ b/configure.ac
@@ -461,7 +461,7 @@ if test "$GCC" = yes -a "x$set_more_warnings" != xno; then
                         -Werror=format-security -Wbitwise -Wcast-to-as \
                         -Wdefault-bitfield-sign -Wdo-while -Wparen-string \
                         -Wptr-subtraction-blows -Wreturn-void -Wtypesign \
-                        -Wstrict-prototypes"
+                        -Wstrict-prototypes -Wno-error=format-nonliteral "
        for option in $warning_options ; do
                SAVE_CFLAGS="$CFLAGS"
                CFLAGS="$CFLAGS $uwoption $option"
diff --git a/goffice/utils/go-format.c b/goffice/utils/go-format.c
index e65d00e..5d558ad 100644
--- a/goffice/utils/go-format.c
+++ b/goffice/utils/go-format.c
@@ -4401,7 +4401,7 @@ SUFFIX(go_format_execute) (PangoLayout *layout, GString *dst,
                }
 
                case OP_NUM_VAL_EXPONENT:
-                       val = SUFFIX (fabs) (exponent);
+                       val = SUFFIX (fabs) (exponent + 0.0);
                        break;
 
                case OP_NUM_STORE_POS:
@@ -8877,7 +8877,7 @@ go_format_output_simple_to_odf (GsfXMLOut *xout, gboolean with_extension,
                                GOFormat const *fmt, GOFormat const *parent_fmt,
                                char const *name, gboolean keep_open)
 {
-       gboolean result;
+       gboolean result = TRUE;
        GOFormatFamily family;
        GOFormatDetails details;
        gboolean exact;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]