[orca] Treat Gecko lists as text block elements (list boxes have a different role)



commit 317e700916f9cd3790c16dd2c9947249a44a71fc
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Mon Sep 15 22:40:32 2014 -0400

    Treat Gecko lists as text block elements (list boxes have a different role)

 src/orca/scripts/toolkits/Gecko/script.py          |    3 ++-
 .../scripts/toolkits/Gecko/script_utilities.py     |    1 +
 test/harness/runall.sh                             |    2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Gecko/script.py b/src/orca/scripts/toolkits/Gecko/script.py
index 3468bb6..634175e 100644
--- a/src/orca/scripts/toolkits/Gecko/script.py
+++ b/src/orca/scripts/toolkits/Gecko/script.py
@@ -1441,7 +1441,8 @@ class Script(default.Script):
         contents = self.getLineContentsAtOffset(focusedObj, focusedOffset)
         contents = self.utilities.filterContentsForPresentation(contents)
         index = self.utilities.findObjectInContents(focusedObj, focusedOffset, contents)
-        if not len(contents) or index == -1:
+        if not len(contents) or \
+           (index == -1 and not self.utilities.isTextBlockElement(focusedObj)):
             default.Script.updateBraille(self, obj, extraRegion)
             return
 
diff --git a/src/orca/scripts/toolkits/Gecko/script_utilities.py 
b/src/orca/scripts/toolkits/Gecko/script_utilities.py
index 38a4a7c..fcb542c 100644
--- a/src/orca/scripts/toolkits/Gecko/script_utilities.py
+++ b/src/orca/scripts/toolkits/Gecko/script_utilities.py
@@ -789,6 +789,7 @@ class Utilities(script_utilities.Utilities):
                              pyatspi.ROLE_DOCUMENT_FRAME,
                              pyatspi.ROLE_FORM,
                              pyatspi.ROLE_HEADING,
+                             pyatspi.ROLE_LIST,
                              pyatspi.ROLE_LIST_ITEM,
                              pyatspi.ROLE_PANEL,
                              pyatspi.ROLE_PARAGRAPH,
diff --git a/test/harness/runall.sh b/test/harness/runall.sh
index b35036a..470bc83 100755
--- a/test/harness/runall.sh
+++ b/test/harness/runall.sh
@@ -167,7 +167,7 @@ do
       #
       mkdir -p ./tmp/$application
       cd ./tmp/$application
-      for testFile in `find $testDir -xtype f -name "aria*.py" | sort`; do
+      for testFile in `find $testDir -xtype f -name "*.py" | sort`; do
         echo ========================================
         echo Running $testFile
         if [ "$found" -gt 0 ]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]