[gnome-shell] popupMenu: Hide separator label when not in use



commit 38d8e465b37e06e935f6d5bbb9da05e1c171f426
Author: Florian Müllner <fmuellner gnome org>
Date:   Sun May 25 16:38:05 2014 +0200

    popupMenu: Hide separator label when not in use
    
    The optional label support introduced in commit af063dc2f2ec broke
    the centering of separators, as the label still adds additional
    spacing even when empty.
    Properly hide the label actor in that case to fix the alignment.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730753

 js/ui/popupMenu.js |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index af0d9e1..d7f3880 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -251,8 +251,16 @@ const PopupSeparatorMenuItem = new Lang.Class({
         this.actor.add(this.label);
         this.actor.label_actor = this.label;
 
+        this.label.connect('notify::text',
+                           Lang.bind(this, this._syncVisibility));
+        this._syncVisibility();
+
         this._separator = new Separator.HorizontalSeparator({ style_class: 'popup-separator-menu-item' });
         this.actor.add(this._separator.actor, { expand: true });
+    },
+
+    _syncVisibility: function() {
+        this.label.visible = this.label.text != '';
     }
 });
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]