[gnome-boxes/gnome-3-12] spice-display: PROPERTIES shouldn't unset resize-guest
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes/gnome-3-12] spice-display: PROPERTIES shouldn't unset resize-guest
- Date: Mon, 19 May 2014 20:47:33 +0000 (UTC)
commit 288f7ce7e769bb22a91737a77ff335157a7820ac
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Mon May 19 19:45:57 2014 +0100
spice-display: PROPERTIES shouldn't unset resize-guest
Don't unset 'resize-guest' property of Spice.Display when going to
properties view as its not just redundant but also makes the display
grow or shrink to fit guest resolution, which could easily go beyond the
screen even.
We don't want our window to grow or shrink on its own and especially to
grow beyond the screen. If user was able to set a particular size on the
window, Boxes must not change it on its own as that would be contrary to
what user expects.
This issue didn't realize before commit 1854c96, where we made the
GtkStack holding most of the views, homogenous.
https://bugzilla.gnome.org/show_bug.cgi?id=730158
src/spice-display.vala | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/spice-display.vala b/src/spice-display.vala
index 05294dd..e43b441 100644
--- a/src/spice-display.vala
+++ b/src/spice-display.vala
@@ -19,11 +19,10 @@ private class Boxes.SpiceDisplay: Boxes.Display {
public bool resize_guest { get; set; }
private void ui_state_changed () {
// TODO: multi display
- if (App.app.ui_state == UIState.PROPERTIES ||
- App.app.ui_state == UIState.DISPLAY) {
+ if (App.app.ui_state == UIState.DISPLAY) {
// disable resize guest when minimizing guest widget
var display = get_display (0) as Spice.Display;
- display.resize_guest = App.app.ui_state == UIState.DISPLAY ? resize_guest : false;
+ display.resize_guest = resize_guest;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]