[gimp-gap] 2nd fix for broken storyboard creation via video extract dialog.



commit f2ef66fa027dc8b77c863670ac4d99dcbb9eeb80
Author: Wolfgang Hofer <wolfgangh svn gnome org>
Date:   Wed Feb 20 20:54:55 2013 +0100

    2nd fix for broken storyboard creation via video extract dialog.

 ChangeLog              |    9 +++++++++
 gap/gap_story_dialog.c |    6 +-----
 2 files changed, 10 insertions(+), 5 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 05212e7..ac172fd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2013-02-20 Wolfgang Hofer <hof gimp org>
+
+- 2nd. bugfix for creation of storyboard from video extract plug-in.
+  fixes crash on attempt to save the created storyboard immediate after creation.
+   [the internal copy of the filename in the GapStoryBoard struct
+    was replaced (OK) but then free'd (NOT OK)]
+
+  * gap/gap_story_dialog.c
+
 2013-02-19 Wolfgang Hofer <hof gimp org>
 
 - storyboard debug features now support logging to file.
diff --git a/gap/gap_story_dialog.c b/gap/gap_story_dialog.c
index 7e04a90..8e43765 100644
--- a/gap/gap_story_dialog.c
+++ b/gap/gap_story_dialog.c
@@ -8558,6 +8558,7 @@ p_storyboard_init_from_creation_params(
     stb->storyboardfile = NULL;
     if(scrp->storyboard_filename[0] != '\0')
     {
+      /* replace the internal copy of the name in the GapStoryBoard struct */
       stb->storyboardfile = g_strdup(scrp->storyboard_filename);
       if(tabw->filename_refptr)
       {
@@ -8567,11 +8568,6 @@ p_storyboard_init_from_creation_params(
               , scrp->storyboard_filename
               );
       }
-      /* replace the internal copy of the name in the GapStoryBoard struct */
-      if(sgpp->cll->storyboardfile)
-      {
-        g_free(sgpp->cll->storyboardfile);
-      }
     }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]