[evolution-kolab/ek-wip-porting: 9/10] EBookBackendKolab: do not clean up KolabMailAccess tables on backend disposal



commit 712e9aaf5a3aed37fa9e46fa44c5c4846e2849a6
Author: Christian Hilberg <hilberg kernelconcepts de>
Date:   Sat Mar 17 23:25:06 2012 +0100

    EBookBackendKolab: do not clean up KolabMailAccess tables on backend disposal
    
    * removing the KolabMailAccess objects in EBookBackendKolab::dispose()
      is the wrong place to do that
    * this part needs overhaul (the KolabMailAccess objects are just
      kept alive now for as long as the backend factory process lives)

 src/addressbook/e-book-backend-kolab.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/addressbook/e-book-backend-kolab.c b/src/addressbook/e-book-backend-kolab.c
index 1f10c8e..e3942f6 100644
--- a/src/addressbook/e-book-backend-kolab.c
+++ b/src/addressbook/e-book-backend-kolab.c
@@ -423,7 +423,7 @@ e_book_backend_kolab_remove (EBookBackendSync *backend,
 	self = E_BOOK_BACKEND_KOLAB (backend);
 	priv = E_BOOK_BACKEND_KOLAB_PRIVATE (self);
 
-	g_error ("%s: FIXME implement me", __func__);
+	g_warning ("%s: FIXME implement me", __func__);
 
 #if 0 /* FIXME old */
 	g_debug ("%s()[%u] called.", __func__, __LINE__);
@@ -1082,16 +1082,17 @@ e_book_backend_kolab_dispose (GObject *object)
 	}
 #endif
 
+	g_warning ("%s()[%u] FIXME KolabMailAccess (table) disposal", __func__, __LINE__);
+#if 0 /* FIXME (check g_object_toggle_ref cleanup callback) */
 	if (priv->book_koma != NULL) {
 		g_object_unref (priv->book_koma);
 		priv->book_koma = NULL;
 	}
-
 	if (priv->koma_table != NULL) {
 		g_hash_table_unref (koma_objects);
 		priv->koma_table = NULL;
 	}
-
+#endif
 	if (priv->book_cache != NULL) {
 		(void) e_file_cache_remove (E_FILE_CACHE (priv->book_cache));
 		g_object_unref (priv->book_cache);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]