[banshee] GConfProxy: Don't use a proxy if the proxy host is empty (bgo#663318)



commit 69b679a4ab71324578e64dc29cf107c7afd441b3
Author: Bertrand Lorentz <bertrand lorentz gmail com>
Date:   Sun Mar 11 13:43:35 2012 +0100

    GConfProxy: Don't use a proxy if the proxy host is empty (bgo#663318)
    
    Based on a patch by Rodrigo Moya. The use_http_proxy key is not
    propagated from GSettings, we keep it for backwards compatibility.

 .../Banshee.GnomeBackend/GConfProxy.cs             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/Backends/Banshee.Gnome/Banshee.GnomeBackend/GConfProxy.cs b/src/Backends/Banshee.Gnome/Banshee.GnomeBackend/GConfProxy.cs
index 4d0d5b2..4e8b761 100644
--- a/src/Backends/Banshee.Gnome/Banshee.GnomeBackend/GConfProxy.cs
+++ b/src/Backends/Banshee.Gnome/Banshee.GnomeBackend/GConfProxy.cs
@@ -121,7 +121,7 @@ namespace Banshee.GnomeBackend
             var proxy_password = Get<string> (null, HTTP_PROXY);
             var proxy_bypass_list = Get<string[]> (HTTP_PROXY, PROXY_BYPASS_LIST);
 
-            if (!use_proxy || proxy_mode == "none") {
+            if (!use_proxy || proxy_mode == "none" || String.IsNullOrEmpty (proxy_host)) {
                 Log.Debug ("Direct connection, no proxy in use");
                 return null;
             }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]