[gnome-bluetooth] lib: fix segfault in "test-deviceselection combo"



commit ccf8c23f8f8b7d15f025af822a54877299722374
Author: Daniele Forsi <dforsi src gnome org>
Date:   Tue Apr 24 21:39:28 2012 +0200

    lib: fix segfault in "test-deviceselection combo"
    
    The combo is a composite widget that contains a chooser.
    Fixes:
    (lt-test-deviceselection:11962): GLib-GObject-WARNING **: attempt to retrieve private data for invalid type 'BluetoothChooser'
    
    Program received signal SIGSEGV, Segmentation fault.
    bluetooth_chooser_get_selected_device_data (self=<optimized out>, column=1) at bluetooth-chooser.c:231
    231		selected = gtk_tree_selection_get_selected (priv->selection, NULL, &iter);
    (gdb) bt
     #0  bluetooth_chooser_get_selected_device_data (self=<optimized out>, column=1) at bluetooth-chooser.c:231
     #1  0x0804a2a8 in response_cb (dialog=0x807f0e0, response_id=-3, selector=0x8084b48) at test-deviceselection.c:207

 lib/test-deviceselection.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/lib/test-deviceselection.c b/lib/test-deviceselection.c
index c3a5bee..fdb7644 100644
--- a/lib/test-deviceselection.c
+++ b/lib/test-deviceselection.c
@@ -332,14 +332,13 @@ create_combo_dialogue (const char *bdaddr)
 		     NULL);
 	g_object_set (G_OBJECT (selector), "device", bdaddr, NULL);
 	bluetooth_chooser_start_discovery (BLUETOOTH_CHOOSER (chooser));
-	g_object_unref (chooser);
 	gtk_container_set_border_width(GTK_CONTAINER(selector), 5);
 	gtk_widget_show(selector);
 	gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (dialog))),
 			    selector, TRUE, TRUE, 0);
 
 	g_signal_connect (G_OBJECT (dialog), "response",
-			  G_CALLBACK (response_cb), selector);
+			  G_CALLBACK (response_cb), chooser);
 
 	return dialog;
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]