[extensions-web] review: Remove terrible premature optimization



commit 7d8cad890d111884fe1d28c0a2e2ff3c848af5cb
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Apr 2 20:35:23 2012 -0400

    review: Remove terrible premature optimization
    
    The cost of constructing a set each loop iteration is not
    worth it.

 sweettooth/review/views.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index d180c49..79af605 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -377,7 +377,7 @@ def safe_to_auto_approve(changes):
         name, ext = os.path.splitext(filename)
 
         # Translations and stylesheet updates are safe.
-        if ext in set(['.mo', '.po', '.css']):
+        if ext in ['.mo', '.po', '.css']:
             continue
 
         # Image updates are safe.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]