[gtk+/gtk-3-0] Make selectable labels work again



commit 1c581263dac0f17454f547d75e08021dff22c0a6
Author: Matthias Clasen <mclasen redhat com>
Date:   Thu Mar 24 12:44:03 2011 -0400

    Make selectable labels work again
    
    You can select something, but moving the focus somewhere else, or bringing up
    the context menu makes the selection go away. This makes it impossible to
    copy-paste the text.
    
    The reason for this regression is that gtk_label_state_changed was sloppy and
    assumed that it would only ever be called when a labels goes insensitive, which
    is no longer the case.
    
    The patch fixes things by explicitly checking if the widget is insensitive, and
    only resetting the selection in that case, which is the same behaviour we have
    for e.g. GtkEntry.

 gtk/gtklabel.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 51fd17f..9f7c7ad 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -3808,7 +3808,9 @@ gtk_label_state_changed (GtkWidget   *widget,
 
   if (priv->select_info)
     {
-      gtk_label_select_region (label, 0, 0);
+      if (!gtk_widget_is_sensitive (widget))
+        gtk_label_select_region (label, 0, 0);
+
       gtk_label_update_cursor (label);
     }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]