[network-manager-openvpn] core: fix HTTP proxy authentication autodetection



commit fc777f42694b55f1d0a47652ce2c8ea2baff7a95
Author: Dan Williams <dcbw redhat com>
Date:   Tue Apr 12 11:18:30 2011 -0500

    core: fix HTTP proxy authentication autodetection
    
    It seems the openvpn doesn't want quotes here, despite the manpage
    indicating that they should be used:
    
     --http-proxy server port [authfile|'auto'|'auto-nct'] [auth-method]
    
    so just strip the quotes off.  The error we get using quotes is:
    
    WARNING: cannot stat file ''auto'': No such file or directory (errno=2)
    Error opening 'HTTP Proxy' auth file: 'auto': No such file or directory (errno=2)

 src/nm-openvpn-service.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/nm-openvpn-service.c b/src/nm-openvpn-service.c
index de86001..f3c25ce 100644
--- a/src/nm-openvpn-service.c
+++ b/src/nm-openvpn-service.c
@@ -786,7 +786,7 @@ nm_openvpn_start_openvpn_binary (NMOpenvpnPlugin *plugin,
 			add_openvpn_arg (args, "--http-proxy");
 			add_openvpn_arg (args, tmp2);
 			add_openvpn_arg (args, tmp3 ? tmp3 : "8080");
-			add_openvpn_arg (args, "'auto'");  /* Automatic proxy auth method detection */
+			add_openvpn_arg (args, "auto");  /* Automatic proxy auth method detection */
 			if (tmp4)
 				add_openvpn_arg (args, "--http-proxy-retry");
 		} else if (!strcmp (tmp, "socks")) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]