[nemiver] Properly initialize RegistersView (Closes: #622796)



commit 30aacd5af06beb3463648f5298e98c3537a6b6bf
Author: Christophe Augier <christophe augier gmail com>
Date:   Tue Sep 7 11:45:42 2010 +0200

    Properly initialize RegistersView (Closes: #622796)
    
    	* src/persp/dbgperspective/nmv-registers-view.cc
    	(RegistersView::Priv::first_run): New member flag.
    	(RegistersView::Priv::finish_handling_debugger_stopped_event):
    	Remove the previous static first_run flag from here as it is now a
    	member of RegistersView::Priv.
    	(RegistersView::clear): Flag the object as needing initialization
    	after we cleared it.

 src/persp/dbgperspective/nmv-registers-view.cc |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/src/persp/dbgperspective/nmv-registers-view.cc b/src/persp/dbgperspective/nmv-registers-view.cc
index f59daef..7080ccb 100644
--- a/src/persp/dbgperspective/nmv-registers-view.cc
+++ b/src/persp/dbgperspective/nmv-registers-view.cc
@@ -61,11 +61,13 @@ public:
     Glib::RefPtr<Gtk::ListStore> list_store;
     IDebuggerSafePtr& debugger;
     bool is_up2date;
-
+    bool first_run;
     Priv (IDebuggerSafePtr& a_debugger) :
         debugger(a_debugger),
-        is_up2date (true)
+        is_up2date (true),
+        first_run (true)
     {
+        first_run = true;
         build_tree_view ();
 
         // update breakpoint list when debugger indicates that the list of
@@ -124,7 +126,6 @@ public:
     void finish_handling_debugger_stopped_event ()
     {
         LOG_FUNCTION_SCOPE_NORMAL_DD;
-        static bool first_run = true;
         if (first_run) {
             first_run = false;
             debugger->list_register_names ();
@@ -311,7 +312,11 @@ void
 RegistersView::clear ()
 {
     THROW_IF_FAIL (m_priv && m_priv->list_store);
+
     m_priv->list_store->clear ();
+    // next time the wiget is used, we'll need to initialize it
+    // again. So mark it as such.
+    m_priv->first_run = true;
 }
 
 }//end namespace nemiver



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]