[gnumeric] goal seek: fix problem with nan.



commit 98a1d9b3306e025daad70a052ded03eab2a3cd03
Author: Morten Welinder <terra gnome org>
Date:   Sun Mar 28 08:26:06 2010 -0400

    goal seek: fix problem with nan.

 NEWS                  |    1 +
 src/tools/ChangeLog   |    8 ++++++--
 src/tools/goal-seek.c |    3 +++
 3 files changed, 10 insertions(+), 2 deletions(-)
---
diff --git a/NEWS b/NEWS
index 82b9e2a..0986951 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ Morten:
 	* Fix filter critical.  [#611073]
 	* Make more menu entries available when an object is selected.
 	* Improve partitioning of status area.
+	* Fix goal seek problem affecting XIRR.  [#614147]
 
 --------------------------------------------------------------------------
 Gnumeric 1.10.1
diff --git a/src/tools/ChangeLog b/src/tools/ChangeLog
index 4eaa357..c0b4dc2 100644
--- a/src/tools/ChangeLog
+++ b/src/tools/ChangeLog
@@ -1,13 +1,17 @@
+2010-03-28  Morten Welinder  <terra gnome org>
+
+	* goal-seek.c (update_data): Properly handle NaNs.  Fixes #614147.
+
 2010-03-26 Andreas J. Guelzow <aguelzow pyrshep ca>
 
-	* auto-correct.c (autocorrect_first_letter_exception): new 
+	* auto-correct.c (autocorrect_first_letter_exception): new
 	(autocorrect_first_letter): don't consider symbols without following
 	  whitespace sentence enders and check for exceptions.
 
 2010-03-26 Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* auto-correct.c (autocorrect_first_letter): implement
-	
+
 2010-03-23 Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* auto-correct.c (AutoCorrectFeature): deleted
diff --git a/src/tools/goal-seek.c b/src/tools/goal-seek.c
index dab1e4f..4314beb 100644
--- a/src/tools/goal-seek.c
+++ b/src/tools/goal-seek.c
@@ -25,6 +25,9 @@
 static gboolean
 update_data (gnm_float x, gnm_float y, GoalSeekData *data)
 {
+	if (!gnm_finite (y))
+		return FALSE;
+
 	if (y > 0) {
 		if (data->havexpos) {
 			if (data->havexneg) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]