[gtk+] Avoid invariant checking spew in gnome-shell



commit e6693ab8402b85b15c3c9711b16423a0e0948de5
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Dec 22 16:53:26 2010 -0500

    Avoid invariant checking spew in gnome-shell
    
    For normal toplevels, visible is tightly bound to mapped, but for
    something like a toplevel that exists within a Clutter stage we
    may want to make mapping dependenton external factors, so we shouldn't
    actually checked that !mapped toplevels are !visible.
    
    Pointed out by Owen Taylor,
    
    https://bugzilla.gnome.org/show_bug.cgi?id=637834

 gtk/gtkwidget.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c
index 66838bc..87834ed 100644
--- a/gtk/gtkwidget.c
+++ b/gtk/gtkwidget.c
@@ -8669,12 +8669,18 @@ gtk_widget_verify_invariants (GtkWidget *widget)
     {
       /* Not mapped implies... */
 
+#if 0
+  /* This check makes sense for normal toplevels, but for
+   * something like a toplevel that is embedded within a clutter
+   * state, mapping may depend on external factors.
+   */
       if (widget->priv->toplevel)
         {
           if (widget->priv->visible)
             g_warning ("%s %p toplevel is visible but not mapped",
                        G_OBJECT_TYPE_NAME (widget), widget);
         }
+#endif
     }
 
   /* Parent related checks aren't possible if parent has



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]