[glom] Tests: Stop using valgrind by default.
- From: Murray Cumming <murrayc src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [glom] Tests: Stop using valgrind by default.
- Date: Fri, 18 Sep 2009 08:07:08 +0000 (UTC)
commit 769e6e08ddda81f7478390be3c37ced692164e2d
Author: Murray Cumming <murrayc murrayc com>
Date: Fri Sep 18 10:07:01 2009 +0200
Tests: Stop using valgrind by default.
* Makefile_tests.am: Do not run all tests under valgrind. valgrind is
for humans to read, and make check has no way to know if the result is
appopriate or not. Run things under valgrind when you want to.
ChangeLog | 8 ++++++++
Makefile_tests.am | 2 +-
tests/import/test_parsing.cc | 6 +++---
3 files changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 552c203..f3a17a2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-09-18 Murray Cumming <murrayc murrayc com>
+
+ Tests: Stop using valgrind by default.
+
+ * Makefile_tests.am: Do not run all tests under valgrind. valgrind is
+ for humans to read, and make check has no way to know if the result is
+ appopriate or not. Run things under valgrind when you want to.
+
2009-09-17 Michael Hasselmann <michaelh openismus com>
Refactoring Dialog_Import_CSV: created testcase for the CsvParser's signal emission
diff --git a/Makefile_tests.am b/Makefile_tests.am
index d2b3bf6..d8dfa7d 100644
--- a/Makefile_tests.am
+++ b/Makefile_tests.am
@@ -36,7 +36,7 @@ TESTS = tests/test_parsing_time \
tests/import/test_parsing\
tests/import/test_signals
-TESTS_ENVIRONMENT=which valgrind && valgrind --tool=memcheck --leak-check=full --leak-resolution=high --trace-children=yes --num-callers=30
+#TESTS_ENVIRONMENT=which valgrind && valgrind --tool=memcheck --leak-check=full --leak-resolution=high --trace-children=yes --num-callers=30
tests_ldadd = glom/libglom/libglom-$(GLOM_ABI_VERSION).la $(LIBGLOM_LIBS)
diff --git a/tests/import/test_parsing.cc b/tests/import/test_parsing.cc
index 49779fd..19928d9 100644
--- a/tests/import/test_parsing.cc
+++ b/tests/import/test_parsing.cc
@@ -52,13 +52,13 @@ void on_line_scanned(const Glib::ustring& line, guint /*line_number*/)
Glib::ustring field;
Glib::ustring::const_iterator line_iter(line.begin());
- while (line_iter != line.end())
+ while(line_iter != line.end())
{
line_iter = Glom::CsvParser::advance_field(line_iter, line.end(), field);
get_tokens_instance().push_back(field);
// Manually have to skip separators.
- if (',' == *line_iter)
+ if(',' == *line_iter)
{
get_tokens_instance().push_back(",");
++line_iter;
@@ -179,7 +179,7 @@ int main()
parser.clear();
}
- std::cout << results.rdbuf();
+ std::cout << results.rdbuf() << std::endl;
return (test_dquoted_string &&
test_skip_on_no_ending_newline &&
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]