[glom] Replace a TODO comment with g_assert_val_if_reached()



commit 66e2d4e2949aa835767e1f9283e580bfd2df978d
Author: Johannes Schmid <jhs jsschmid de>
Date:   Thu Sep 17 18:26:05 2009 +0200

    Replace a TODO comment with g_assert_val_if_reached()
    
    Reaching this branch would mean that the dialog returned an unhandled response.

 ChangeLog           |    7 +++++++
 glom/application.cc |    3 ++-
 2 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index a9c339b..7cdb161 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2009-09-17  Johannes Schmid  <jschmid openismus com>
 
+	* glom/application.cc: offer_new_or_existing():
+	Replace a TODO comment with g_assert_val_if_reached() because
+	reaching this branch would mean that the dialog returned
+	an unhandled response.
+
+2009-09-17  Johannes Schmid  <jschmid openismus com>
+
 	* regression_tests/test_python_module.cc:
 	* Makefile_tests.am:
 	Added a regression test for the loading of the python modules.
diff --git a/glom/application.cc b/glom/application.cc
index 59960c9..17b9f0e 100644
--- a/glom/application.cc
+++ b/glom/application.cc
@@ -1356,7 +1356,8 @@ bool App_Glom::offer_new_or_existing()
     }
     else
     {
-      //Do nothing. TODO: Do something?
+      // This would mean that we got a unhandled response from the dialog
+      g_return_val_if_reached(false);
     }
   }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]