banshee r3988 - in trunk/banshee: . src/Libraries/Hyena.Gui/Hyena.Widgets



Author: gburt
Date: Tue May 27 22:55:23 2008
New Revision: 3988
URL: http://svn.gnome.org/viewvc/banshee?rev=3988&view=rev

Log:
2008-05-27  Gabriel Burt  <gabriel burt gmail com>

	* src/Libraries/Hyena.Gui/Hyena.Widgets/RatingMenuItem.cs:
	* src/Libraries/Hyena.Gui/Hyena.Widgets/RatingEntry.cs: Fix bug where
	preview-on-hover stars weren't cleared before showing the track context
	menu (or notification menu) so you'd see whatever hover stars had been
	there the last time you opened it (even if for another track).  Fixes BGO
	#534460.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingEntry.cs
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingMenuItem.cs

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingEntry.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingEntry.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingEntry.cs	Tue May 27 22:55:23 2008
@@ -285,7 +285,7 @@
         
         protected override bool OnLeaveNotifyEvent (Gdk.EventCrossing crossing)
         {
-            hover_value = renderer.MinRating - 1;
+            ClearHover ();
             QueueDraw ();
             return true;
         }
@@ -329,6 +329,11 @@
 
 #region Internal API, primarily for RatingMenuItem
         
+        internal void ClearHover ()
+        {
+            hover_value = renderer.MinRating - 1;
+        }
+
         internal bool HandleKeyPress (Gdk.EventKey evnt)
         {
             return this.OnKeyPressEvent (evnt);

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingMenuItem.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingMenuItem.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Widgets/RatingMenuItem.cs	Tue May 27 22:55:23 2008
@@ -127,6 +127,7 @@
         {
             can_activate = false;
             Value = value;
+            entry.ClearHover ();
             can_activate = true;
         }
         



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]