Re: Possible source error, 2.4.0

[Peter Bloomfield <peterbloomfield bellsouth net>]

On 06/25/2009 04:17:43 PM Thu, Geoffrey Leach wrote:
> On 06/24/2009 10:10:40 PM, Pawel Salek wrote:
> > On 06/25/2009 01:25:56 AM, Geoffrey Leach wrote:
> > > In the file spell-check.c, the position of
> > >   #include "spell-check.h"
> > > leads to compile failure, as GType is not defined at that point
> >
> > Does the attached patch fix the problem?
>
> Hmmmm .... well, this is a bit embarassing :-) I fixed the problem by
> moving include "spell-check.h" in spell-check.c to after line 48, which
> solved the problem. The patch generates further compile errors, BUT I
> may not have moved the include back to the correct place.

I seem to recall reading somewhere that including a module's own header  
immediately after config.h is good practice--that way, it must include all  
the headers for the types that it uses, so it's safe to include anywhere.   
So testing the patches /without/ moving the include would be really  
helpful :)