Re: [Planner Dev] New patch for undo: Focus in - focus out undo



On mån, 2004-04-19 at 06:10 +0000, Alvaro del Castillo wrote:

Hi,

> > +       g_value_set_string (&value, g_strdup (focus_in_name));
> >
> > This will leak, no need for the strdup.
> 
> Hmmm, g_value_unset doesn't free the string memory?

g_value_set_string does it's own g_strdup of the string, so you'll copy
the string twice here but only free it once in g_value_unset.

Regards,
  Mikael Hallendal
-- 
Imendio HB, http://www.imendio.com/

Attachment: signature.asc
Description: Detta =?ISO-8859-1?Q?=E4r?= en digitalt signerad meddelandedel



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]