Re: Temp file patches

[Jakub Jelinek <jakub redhat com>]

On Wed, Jul 07, 2004 at 03:09:08PM +0200, Leonard den Ottolander wrote:
> Hi,
> 
> Let's see if sending a patch to the list now succeeds.
> 
> The temp file patch I sent to Pavel before contains two hunks that don't
> patch against CVS, because a different code page is now used (or are
> they converted during the rpm build?). Also added are similar temp file
> fixes for doc/pl/mc.1.in and doc/sr/mc.1.in, which I mentioned before.
> 
> Please note any omissions you find.
> 
> This brings up the question of the code pages used for docs. Would it be
> a good idea to code all docs in UTF-8?

--- mc.000/lib/cedit.menu       2003-08-03 01:01:51.000000000 +0200
+++ mc/lib/cedit.menu   2004-07-07 14:49:44.000000000 +0200
@@ -454,7 +454,7 @@ s       Invoke `shell'

 m       view `man'
         MAN=%{Enter name of man:}
-        TMPFILE=/tmp/mcview.$MAN.$$
+        TMPFILE=`mktemp ${MC_TMPDIR:-/tmp}/mcview.$MAN.$$` || exit 1
         man -Pcat $MAN >$TMPFILE
         mcview $TMPFILE
         rm -f $TMPFILE

This is not correct, should be
mktemp ${MC_TMPDIR:-/tmp}/mcview.$MAN.XXXXXX

	Jakub