Re: Familiy name in Alias and alias brokeness.



>>>>> On 01 Feb 2003 14:31:27 -0500,
>>>>> "CC" == Chema Celorio <chema ximian com> wrote:

CC> 1. - Family for aliases need to have the alias familyname, not the
CC> font's familiy name. This is the bug reported by Radek. I've filed it
CC> as:
CC> http://bugzilla.gnome.org/show_bug.cgi?id=105006
CC> and attached a patch:
CC> http://bugzilla.gnome.org/showattachment.cgi?attach_id=14026

CC> I'd like to get confirmation from Radek that the patch fixes his issue.

CC> Also, Akira TAGOH said:
CC> "Your patch breaks the printing, because psname is given from the ..."

CC> I think Radek's patch doesn't introduce that problem, the problem is
CC> there even without Radek's patch.

Yeah, that problem was just clearly seen by Radek's patch.
The codes you've commited works fine.

CC> 3. - We are treating aliases inside the code as real fonts. There is
CC> code that is using GP_FONT_ENTRY_ALIAS which we are no longer using when
CC> loading the fontmap.

CC> [chema lamark libgnomeprint]$ grep  GP_FONT_ENTRY_ALIAS *.c
CC> gnome-font-face.c:                      if (entry->type == GP_FONT_ENTRY_ALIAS)
CC> gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {
CC> gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {
CC> gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {

CC> I changed the code from using a entry type alias, to use a ->is_alias
CC> flag. The reason for that is because I am preparing the move to pango
CC> and having the fontmap know less about the fonts (like what format the
CC> fonts are in) is going to be needed for the pango move. The way aliases
CC> are being identified right now can be explained by:
CC> http://bugzilla.gnome.org/showattachment.cgi?attach_id=13684

Well, is there any reason that gnome-print still needs to be
having the fontmap file? I think the cost of getting these
info dynamically is lower than the reading/writing/managing
.fontmap file.


Regards,
--
Akira TAGOH



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]