Re: gok-1.0.5 break on joystick.h

["Joseph E. Sacco, PhD" <joseph_sacco comcast net>]

Some distributions install the set of linux include files that were used
to build glibc. Others install the set of linux include files that were
used to build the current kernel. The include files used to build glibc
are typically older than those used to build the kernel. That being
said, there is considerable variation in what is included where.

Take a look at <linux/joystick.h> and you will most likely see that it
contains <asm/types.h>. On my 32-bit system <asm/types.h> contains


        #ifdef __KERNEL__
        /*
         * These aren't exported outside the kernel to avoid name space
        clashes
         */
        #define BITS_PER_LONG 32

which means BIT_PER_LONG is defined only when the macro __KERNEL__ is
set.

What to do??? 

Setting __KERNEL__ when building gok is a huge mistake that will cause
you much grief. 

What I would do is add the following to joystick.h

#ifndef BITS_PER_LONG
#define BITS_PER_LONG 32
#endif

somewhere near the top of the file.

If you are working on a 64 bit system, adjust according to what you
found in <asm/types.h>

-Joseph

===============================================================================
On Fri, 2005-11-25 at 09:56 +0100, Sasa Ostrouska wrote:
> Hi friends, its again me, now I get a break here:
> 
[snip]
> In file included from switchapi.c:37:
> /usr/include/linux/joystick.h:142:2: #error Unexpected BITS_PER_LONG
> make[5]: *** [switchapi.o] Error 1
> make[5]: Leaving directory
> `/home/test/garnome-2.13.2/desktop/gok/work/main.d/gok-1.0.5/gok'
> make[4]: *** [all-recursive] Error 1
> make[4]: Leaving directory
> `/home/test/garnome-2.13.2/desktop/gok/work/main.d/gok-1.0.5'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory
> `/home/test/garnome-2.13.2/desktop/gok/work/main.d/gok-1.0.5'
> make[2]: *** [build-work/main.d/gok-1.0.5/Makefile] Error 2
> make[2]: Leaving directory `/home/test/garnome-2.13.2/desktop/gok'
> make[1]: *** [../../desktop/gok/cookies/main.d/install] Error 2
> make[1]: Leaving directory
> `/home/test/garnome-2.13.2/desktop/gnopernicus'
> make: *** [paranoid-install] Error 2
> test rc-vaio:~/garnome-2.13.2/desktop$
> 
> I'm using kernel 2.6.15-rc2
> 
> Rgds
> Saxa
> 
-- 
joseph_sacco [at] comcast [dot] net