Re: [evolution-patches] #54338:Problem with vFolders of same name.



You can't make 2 vfolders have the same name because there'd be no way
to show it in the folder-tree (only one folder of any given name can
exist in the tree).

As notzed mentioned in his email earlier in this thread, you need to
find out why a vfolder of the same name is not being found properly and
fix that.

Jeff

On Mon, 2004-02-16 at 01:14, Bill Zhu wrote:
> I have looked through the source code again.
> I find the reason why this bug exists. It is because the vfolders are
> stored in a hash table where using their folder name as their hash key.
> I am thinking about how to make it possible to allow them share same
> name.
> 
> 
> 在2004年02月15日的00:07,Jeffrey Stedfast写道:
> > we should allow vfolders and filters to share the same names. we should
> > also allow 2 filters to share the same name *if* their sources are
> > different.
> > 
> > Jeff
> > 
> > On Sat, 2004-02-14 at 01:38, Bill Zhu wrote:
> > > I got it, The filter and vfolder are using the same dialog.
> > > I think it is a hard work to permit the existance of rules with same
> > > name.Because I find tons of bugs caused by permitting this. for example
> > > adding two rules but just one vfolder,and when I delete one of the
> > > rules,the other is deleted too.
> > > so I think may be it is a good solution to make 2 vfolders cann't have
> > > the same name. although it affects filters, it is also ok. Can we make
> > > the filters cann't have the same name neither?
> > > 
> > > 
> > > 在2004年02月14日的00:26,Jeffrey Stedfast写道:
> > > > this patch is wrong, it is perfectly valid to have 2 filters named the
> > > > same where the sources differ. If you want to make it so that 2 vfolders
> > > > cannot have the same name, that's fine, but this patch also affects
> > > > filters.
> > > > 
> > > > Jeff
> > > > 
> > > > On Fri, 2004-02-13 at 09:49, Bill Zhu wrote:
> > > > > The rule-editor judges whether two rules is identical by both the rule
> > > > > name and the source. We need judge only by rule name.	
> > > > > because there should not exist two rules has the same name.
> > > > > 	http://bugzilla.ximian.com/show_bug.cgi?id=54338
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]