quote colors



Hi,

I found it somewhat exagerated to define six colors for quoted text,  
having two alternating ones should be completely fine IMHO, and thus I  
made this patch against 2.0.15, reducing prefs a little.

I was afraid of changing a string, but it would be necessary for a  
cleaner implementation. Maintainers should decide, if accepted. :)

Darko Obradovic
diff -ruN balsa-2.0.15/src/balsa-app.h balsa-2.0.15-alternating_quotes/src/balsa-app.h
--- balsa-2.0.15/src/balsa-app.h	2003-09-28 20:41:24.000000000 +0200
+++ balsa-2.0.15-alternating_quotes/src/balsa-app.h	2003-10-28 21:24:34.000000000 +0100
@@ -75,7 +75,7 @@
  * Default colour for quoted text
  * oh no, I used the US spelling.
  */
-#define MAX_QUOTED_COLOR 6
+#define MAX_QUOTED_COLOR 2
 #define DEFAULT_QUOTED_COLOR "#055"
 #define DEFAULT_QUOTE_REGEX  "^[ \\t]*[|>:}#]"
 
diff -ruN balsa-2.0.15/src/pref-manager.c balsa-2.0.15-alternating_quotes/src/pref-manager.c
--- balsa-2.0.15/src/pref-manager.c	2003-09-24 12:16:13.000000000 +0200
+++ balsa-2.0.15-alternating_quotes/src/pref-manager.c	2003-10-28 21:41:13.000000000 +0100
@@ -2197,32 +2197,17 @@
 message_colors_group(GtkWidget * page)
 {
     GtkWidget *group;
-    GtkWidget *hbox;
-    GtkWidget *vbox1;
-    GtkWidget *vbox2;
+    GtkWidget *vbox;
     gint i;
     
     group = pm_group_new(_("Message Colors"));
-    hbox = gtk_hbox_new(TRUE, 3 * HIG_PADDING);
-    pm_group_add(group, hbox);
-
-    vbox1 = gtk_vbox_new(FALSE, HIG_PADDING);
-    vbox2 = gtk_vbox_new(FALSE, HIG_PADDING);
-    gtk_box_pack_start(GTK_BOX(hbox), vbox1, TRUE, TRUE, 0);
-    gtk_box_pack_start(GTK_BOX(hbox), vbox2, TRUE, TRUE, 0);
+    vbox = gtk_vbox_new(TRUE, HIG_PADDING);
+    pm_group_add(group, vbox);
 
     for(i = 0; i < MAX_QUOTED_COLOR; i++) {
-        GtkWidget *current_vbox;
-	gchar *text = g_strdup_printf(_("Quote level %d color"), i+1);
-
-        if (i < MAX_QUOTED_COLOR/2) {
-            current_vbox = vbox1;
-        } else {
-            current_vbox = vbox2;
-        }
-        
-	pui->quoted_color[i] = color_box( GTK_BOX(current_vbox), text);
-	g_free(text);
+        gchar *text = g_strdup_printf(_("Quote level %d color"), i+1);
+        pui->quoted_color[i] = color_box( GTK_BOX(vbox), text);
+        g_free(text);
     }
 
     return group;

PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]