Re: [xslt] 1.1.15 test failure on IRIX 6.5



On Fri, Nov 11, 2005 at 05:50:09PM -0600, Albert Chin wrote:
> $ gmake check
> ...
> ## Running exslt common tests
> add.1 result
> 13c13 < result : 1999-12-31 --- > result : 1999-12-30 17c17 < result : -0001-12-31T23:59:59Z --- > result : -0001-12-30T23:59:59Z 19c19 < result : 1999-12-31T23:59:01Z --- > result : 1999-12-30T23:59:01Z 21c21 < result : -0002-12-31T23:59:01Z --- > result : -0002-12-30T23:59:01Z 25c25 < result : 1999-12-31 --- > result : 1999-12-30 27c27 < result : 1999-12-31 --- > result : 1999-12-30
> 
> Fix below. Does this make sense to anyone?

  yes, we are starting from an unsigned int and substracting 1, I don't think
we want this to roll back to 15  but get -1 instead (this is declared as 
4 bit unsigned). This makes sense to me, and I am fixing _xmlSchemaDateAdd()
in libxml2 too accordingly.
  It is somewhat strange that libxslt raises errors on date types while
apparently the Schemas regression tests don't spotted this, but heh more tests
means more bugs :-)
  Fixed in both libexslt and libxml2 and commited,

    thanks a lot !

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]