Re: [xslt] thread-safe function for libexslt

[Daniel Veillard <veillard redhat com>]

On Thu, Feb 26, 2004 at 04:50:50PM +0800, William M. Brack wrote:
> There is an outstanding bug report
> (http://bugzilla.gnome.org/show_bug.cgi?id=129983) requesting that
> the call within libexslt to the function "localtime" be changed to a
> call to "localtime_r" when libxslt is generated with threading
> enabled.  That is certainly quite alright on my system, but I'm not
> certain whether it might have any "bad" effect on some other OS's. 
> Does anyone have any good reason why I should not go ahead and
> commit this change?

  Well, making 100% sure we test in configure that said function exists
and of course the patch doesn't include that part which is where the
hard part of implementing said change actually is. So if you add the
test for localtime_r in configure.in, regenerate the config.h.in,
add the proper #ifdef / #endif , then it will work. Of course applying
the patch directly without testing for the platform support is just
asking to get 10 times more bug reports at the next release.

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard@redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/