RE: [xslt] xsltconfig.h.in or me?



Good morning Europe,

> I'd forgotten what the WITH_XSLT_DEBUGGER MACRO 
> was for. It was provided for the libxslt 
> application to test whether debugger support was 
> compiled into libxslt or not. At this time is 
> realy only useful to xsldbg related products.
>
> So far I check this only under *nix in configure 
> scripts, though Igor made me realize I was 
> checking for the wrong MACRO name :-( And in the 
> past this method has been not easy to support 
> under other platforms.
> 
> I'm thinking of changing the way I handle this.  
> A possible solution would be continue to have 
> WITH_XSLT_DEBUGGER, or some other name, in 
> xsltconfig.h.in and the application do a check on 
> the value of that name in their header file eg

Well, then there are two possible solutions:

1. Apps outside libxslt could forget about WITH_XSLT_DEBUGGER and use
WITH_DEBUGER instead.
2. I could put WITH_XSLT_DEBUGGER back into xsltconfig.h.in and replace
every occurrence of WITH_DEBUGGER with WITH_XSLT_DEBUGGER in libxslt
source files. 

Either way works for me. Number 1 is allready in place and if you or
anyone else cannot live with it, I'll do the number 2. If someone out
there cannot live with either of these, then I'll do the number 3, which
means revert the change to xsltconfig.h.in and solve the problem in the
makefile. However, number 3 leaves the source in an inconsistent state,
means defining one macro and checking for existence of another. If
someone wants this to be so, she better have a good reason :-)

Ciao
Igor



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]