Re: Source code encoding detection modifications for intltool



On 2003-07-14(Mon) 20:34:18 +0200, Carlos Perelló Marín wrote:
> Hi, here you have a patch that tries to detect the file encoding used
> and then, calls xgettext with that encoding option.

An unexpected failure -- currently escaped hex values (\x??) are not
handled. Source code with such strings should most likely use
--from-code=UTF-8 too, but "file" detects them as either ASCII or ISO-*
files. (mlview/src/mlview-app.c for example)

It's not easy to determine what encoding is represented by escaped hex
values -- it can be UTF-8, or can be something else, though it's most
likely UTF-8 in GNOME 2.x software.

Abel

> Please, test it and review it I have no idea about perl so my change
> it's mainly a cut & paste fix
> 
> I will also prepare a gettext >= 0.12 check so new intltool releases
> will require it to be able to deal with UTF-8 source files.
> 
> Some comments. I get the file encoding with the "file" command and thus,
> I'm not able to know  the XML and yacc files encoding, so I'm assuming
> that XML files are UTF-8 and any other file that it's not UTF-8, ISO* or
> XML is ASCII
> 
> Comments, ideas?
> 
> I will apply this patch to my intltool installation so the status pages
> will start to use it.
-- 
Abel Cheung
Linux counter #256983   | http://counter.li.org
GPG Key: (0xC67186FF)   | http://deaddog.org/gpg.asc
Key fingerprint: 671C C7AE EFB5 110C D6D1  41EE 4152 E1F1 C671 86FF

Attachment: pgpYfnR7ZipST.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]